Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork993
[WIP] ENH: add preliminary support for using spherely as geometry engine#3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jorisvandenbossche wants to merge1 commit intogeopandas:mainChoose a base branch fromjorisvandenbossche:spherely-support
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
martinfleis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
more later...
| """ | ||
| # TODO raise for unsupported keyword (and pass through spherely-speficic kwargs) | ||
| return GeographyArray(shapely.from_wkb(data), crs=crs) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| returnGeographyArray(shapely.from_wkb(data),crs=crs) | |
| returnGeographyArray(spherely.from_wkb(data),crs=crs) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Very much work-in-progress POC of using spherely in geopandas as another geometry engine.
While there are many things to do or improve (implementing some basic things like astype and to_crs, but also just making the NotImplementedErrors more informative with a clear message, or changing them to a TypeError if we think it will never be implemented for spherical geometries; move common parts to a base class, etc), the current PR already does allow some basic things. Seehttps://gist.github.com/jorisvandenbossche/2e8ecee0d109b77e03c45fca7bac385a for an overview.
The approach currently taken here is: have a separate ExtensionArray class (currently called
GeographyArray), while keeping the singleGeometryDtypeclass but parametrizing it with anengineparameter (currently with values "planar" (default) and "spherical"; one question with this approach is if we want to describe the type of the engine (planar vs spherical) vs the package being used (shapely vs spherely). I like the type more, but at some point we might also have more than one engine for planar geometries).This means you can do something like to convert an existing geometry column to use the spherical support:
Of course, we could also add a dedicated method for this conversion (
as_sphericalorto_sphericalor something like that) if that might be easier to use vs the generic type casting.While I took the approach of the parametrized dtype here (instead of different subclasses), I think I am now rather leaning towards going for subclasses .. (moving to that model is a relatively small code change)
xref#2769