Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

InGeoDataFrame.to_parquet renamegeoarrow keyword argument tonative#3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kylebarron wants to merge1 commit intogeopandas:main
base:main
Choose a base branch
Loading
fromkylebarron:kyle/native-kwarg-to-parquet

Conversation

@kylebarron
Copy link
Contributor

I've had multiple people ask me what thegeometry_encoding="geoarrow" keyword does. We're writing to GeoParquet... but this is GeoArrow in GeoParquet? Huh?

I think the term "GeoArrow" is too overloaded, where here it refers to the "geoarrow-like" geometry encoding, rather than the in-memory format. I think it would be clearer to have users refer to the GeoParquet encoding as "native" rather than "geoarrow".

@m-richards
Copy link
Member

I understand the rationale with wanting to make this change, and appreciate that since you're building tools leveraging geoarrow you're getting more exposure to people using it than I am - I can only speak for me and my experience naming things. Happy to be shot down or for other suggestions.

But I worry that "native" is also prone to mis-interpretation and might lead to confusion with platform native code with an incorrect assumption about the encoding being platform / architecture specific. "native" also doesn't align nicely with the terminology in the geoparquet spec, which refers to the "single-geometry type encodings based on theGeoArrow specification."

I wonder if this would just benefit from improving the existing documentation - with what's already written we don't exactly explain what is meant by encoding - and that sounds like part of the problem from the question you've phrased. Would it be clearer if geometry_encoded also supported recieving the single-geometry type encodings, and we explain that "geoarrow" is a convenience alias to infer the appropriate single-geometry type?

@kylebarron
Copy link
ContributorAuthor

The heading in the GeoParquet spec says"native encodings (based on GeoArrow)".

I think thus it would be clearer to use "native" to emphasize that these geoarrow-like encodings are not exactly geoarrow.

@martinfleis
Copy link
Member

We discussed this during the dev call and are happy with this alias.@kylebarron can you just add a simple test ensuring the alias is covered?

@kylebarron
Copy link
ContributorAuthor

Should we think about a coherent plan for what API we want to expose for users to create native Parquet geometry/geography types? And ensure that this rename doesn't conflict with that goal

@martinfleis
Copy link
Member

Should we think about a coherent plan for what API we want to expose for users to create native Parquet geometry/geography types? And ensure that this rename doesn't conflict with that goal

@jorisvandenbossche you mentioned something during the call some time ago, do you remember what you wanted to do regarding support of native Parquet?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kylebarron@m-richards@martinfleis

[8]ページ先頭

©2009-2025 Movatter.jp