Commit3e95ab1

committed

Fixed caching to be provider-dependent.

1 parent2cd8813 commit3e95ab1Copy full SHA for 3e95ab1

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).`
`5`	`5`	`##[4.3.4] - 2020-06-21`
`6`	`6`	`###Fixed`
`7`	`7`	`- non-caching declaration to only apply to current query.`
	`8`	`+- caching to take provider into account.`
`8`	`9`
`9`	`10`	`###Changed`
`10`	`11`	-`getProvider()` method to no longer be deprecated, and instead return the

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ protected function cacheRequest(string $cacheKey, array $queryElements, string $`
`197`	`197`	`returncollect($this->aggregator->{$queryType}(...$queryElements));`
`198`	`198`	`}`
`199`	`199`
`200`		`-$hashedCacheKey =sha1($cacheKey);`
	`200`	`+$hashedCacheKey =sha1($this->getProvider()->getName() ."-" .$cacheKey);`
`201`	`201`	`$duration =config("geocoder.cache.duration",0);`
`202`	`202`	`$store =config('geocoder.cache.store');`
`203`	`203`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,10 @@ public function testGeocoder()`
`160`	`160`
`161`	`161`	`publicfunctiontestCacheIsUsed()`
`162`	`162`	`{`
`163`		`-$cacheKey =sha1(Str::slug(strtolower(urlencode('1600 Pennsylvania Ave NW, Washington, DC 20500, USA'))));`
	`163`	`+$cacheKey =sha1(`
	`164`	`+app('geocoder')->getProvider()->getName()`
	`165`	`+ ."-" . Str::slug(strtolower(urlencode('1600 Pennsylvania Ave NW, Washington, DC 20500, USA')))`
	`166`	`+ );`
`164`	`167`
`165`	`168`	`$result =app('geocoder')`
`166`	`169`	`->geocode('1600 Pennsylvania Ave NW, Washington, DC 20500, USA')`
`@@ -271,7 +274,9 @@ public function testGetProvider()`
`271`	`274`
`272`	`275`	`publicfunctiontestJapaneseCharacterGeocoding()`
`273`	`276`	`{`
`274`		`-$cacheKey =sha1(Str::slug(strtolower(urlencode('108-0075 東京都港区港南２丁目１６－３'))));`
	`277`	`+$cacheKey =sha1(app('geocoder')->getProvider()->getName()`
	`278`	`+ ."-" . Str::slug(strtolower(urlencode('108-0075 東京都港区港南２丁目１６－３')))`
	`279`	`+ );`
`275`	`280`
`276`	`281`	`app('geocoder')`
`277`	`282`	`->geocode('108-0075 東京都港区港南２丁目１６－３')`

Comments

(0)