Commit20b2629

committed

Fixed geocoder to not cache if results are empty

1 parent488cd65 commit20b2629Copy full SHA for 20b2629

File tree

+31

-0

lines changed

+31

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,11 @@`
`2`	`2`	`All notable changes to this project will be documented in this file.`
`3`	`3`	`This project adheres to[Semantic Versioning](http://semver.org/).`
`4`	`4`
	`5`	`+##[4.0.3] - 27 Oct 2017`
	`6`	`+###Fixed`
	`7`	`+- cache duration to work on 32-bit systems.`
	`8`	`+- geocoder to not cache if no results are provided.`
	`9`	`+`
`5`	`10`	`##[4.0.2] - 2 Sep 2017`
`6`	`11`	`###Fixed`
`7`	`12`	- erroneous method`getProvider()` and marked it as deprecated.

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,8 @@ function () use ($query) {`
`88`	`88`	`}`
`89`	`89`	`);`
`90`	`90`
	`91`	`+$this->removeEmptyCacheEntry("geocoder-{$cacheKey}");`
	`92`	`+`
`91`	`93`	`return$this;`
`92`	`94`	`}`
`93`	`95`
`@@ -102,6 +104,8 @@ function () use ($query) {`
`102`	`104`	`}`
`103`	`105`	`);`
`104`	`106`
	`107`	`+$this->removeEmptyCacheEntry("geocoder-{$cacheKey}");`
	`108`	`+`
`105`	`109`	`return$this;`
`106`	`110`	`}`
`107`	`111`
`@@ -121,6 +125,8 @@ function () use ($value) {`
`121`	`125`	`}`
`122`	`126`	`);`
`123`	`127`
	`128`	`+$this->removeEmptyCacheEntry("geocoder-{$cacheKey}");`
	`129`	`+`
`124`	`130`	`return$this;`
`125`	`131`	`}`
`126`	`132`
`@@ -135,6 +141,8 @@ function () use ($latitude, $longitude) {`
`135`	`141`	`}`
`136`	`142`	`);`
`137`	`143`
	`144`	`+$this->removeEmptyCacheEntry("geocoder-{$cacheKey}");`
	`145`	`+`
`138`	`146`	`return$this;`
`139`	`147`	`}`
`140`	`148`
`@@ -239,4 +247,13 @@ protected function getAdapterClass(string $provider) : string`
`239`	`247`
`240`	`248`	`returnconfig('geocoder.adapter');`
`241`	`249`	`}`
	`250`	`+`
	`251`	`+protectedfunctionremoveEmptyCacheEntry(string$cacheKey)`
	`252`	`+ {`
	`253`	`+$result =app('cache')->get($cacheKey);`
	`254`	`+`
	`255`	`+if ($result &&$result->isEmpty()) {`
	`256`	`+app('cache')->forget($cacheKey);`
	`257`	`+ }`
	`258`	`+ }`
`242`	`259`	`}`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -308,4 +308,13 @@ public function testItHandlesOnlyCityAndState()`
`308`	`308`	`$this->assertEquals('Washington',$results->first()->getAdminLevels()->first()->getName());`
`309`	`309`	`$this->assertEquals('United States',$results->first()->getCountry()->getName());`
`310`	`310`	`}`
	`311`	`+`
	`312`	`+publicfunctiontestEmptyResultsAreNotCached()`
	`313`	`+ {`
	`314`	`+$cacheKey =str_slug(strtolower(urlencode('_')));`
	`315`	`+`
	`316`	`+ Geocoder::geocode('_')->get();`
	`317`	`+`
	`318`	`+$this->assertFalse(app('cache')->has("geocoder-{$cacheKey}"));`
	`319`	`+ }`
`311`	`320`	`}`

Comments

(0)