👍

Also, Symfony 3.1 will have a Cache component.

Oh didn't know that, but wouldn't it be better to build against thepsr/cache interface?

I've implemented it in the Drupal module using custom code, without strategy. Code here:https://github.com/drupol/geocoder/blob/8.x-2.x/src/Plugin/Geocoder/Provider.php#L72

@Baachi Symfony added the PSR-6 implementationsymfony/symfony#17408 :)

@toin0u Cool didn't know that 👍

See#487 if it's only for HTTP request we (php-http) already provide a plugin for caching response with PSR6, this will maybe allow to reduce the maintenance on your side

@joelwurtz I know that httplug have a caching system but it uses thecache-control header and many providers doesn't set cache control header.
I would like to have a caching strategy which cover the following use cases:

• The user hit the api limit, so load it from the cache so he have at least a result
• The user wants to reduce the api limit, so use a cache

If this is possible through httplug, let me know.

The user wants to reduce the api limit, so use a cache

The CachePlugin as an option to respect / ignore cache headers :respect_cache_headers, si if the request is within an acceptable method (GET or HEAD) and an acceptable status code (200, 203, 300, 301, 302, 404, 410) it is cached, even if the cache-control was set tono-cache.

The user hit the api limit, so load it from the cache so he have at least a result

In fact theCachePlugin has a protected method to determine if the response is cacheable or not (seehttps://github.com/php-http/plugins/blob/master/src/CachePlugin.php#L104). So for this use case you can extend the cache plugin and implementing the rule for api limit.

You also give me an idea about introducing a StaleCachePlugin, like caching response in another cache with a longer ttl, and if a following request / response is in failure, it reuse the cached one.

@joelwurtz This sounds indeed interesting and would also cover this use case.

In fact the CachePlugin has a protected method to determine if the response is cacheable or not (seehttps://github.com/php-http/plugins/blob/master/src/CachePlugin.php#L104). So for this use case you can extend the cache plugin and implementing the rule the api limit.

Yes this is right, but how would you detect if there is an error in this response? Geocoder already know this already and throw an exception if the provider hit the api limit or there is an other error.

@geocoder-php/geocoder ready for review 👍

@Baachi Good job! It looks good 👍 Just few missing phpdocs :)

👍

@Baachi any update on this PR?

Will try to finish up this PR this week.

FYI: One could use the CachePlugin to HTTPlug.

@willdurand do you still want this PR? If yes i will add the missing docs

Do we need this PR?
See this cookbook:https://github.com/geocoder-php/Geocoder/blob/master/docs/cookbook/cache.md

Doesn't that solve the cache problem for us?

@Nyholm this is the question, the only thing which isn't currently not covered is thestale-if-error strategy. But of course i can also open a PR to HTTPLug to cover this case.

I would vote for not merging this and addstale-if-error on thehttps://github.com/php-http/cache-plugin

@Nyholm Should i open an issue on thephp-http/cache-plugin repo to discuss the implementation or are you okay with this implementation?

I think this implementation looks good. Since it is not too much code, I suggest to open a quick PR and we'll discuss it there. Do not spend too much time (or none) at the tests until you got some feedback.
There are some people watching that repo that are really skilled at HTTP cache. I guess they will have some input as well.

@Nyholm

Is this PR still needed?
It seems we have aCacheProvider in the package, as well as instructions on how to use the httplug cache?

I think this PR is not needed anymore :)
Sadly i didn't have time, to finish it 😢

Thanks@Baachi 😄