Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

tests: fix deprecation from PHPUnit#1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Chris53897 wants to merge3 commits intogeocoder-php:master
base:master
Choose a base branch
Loading
fromChris53897:feature/fix-warning-for-tests

Conversation

@Chris53897
Copy link
Contributor

There was 1 warning:1) Geocoder\Provider\GeoIP2\Tests\GeoIP2AdapterTest::testReaderResponseIsJsonEncodedassertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() instead.

@jbelienjbelien marked this pull request as draftMarch 2, 2024 11:09
@jbelien
Copy link
Member

jbelien commentedMar 2, 2024•
edited
Loading

That breaks all "(low)" checks. I would wait until we upgrade to PHPUnit 10 before making that change.

@Chris53897
Copy link
ContributorAuthor

This is maybe solved by#1218 with Raising minimum PHPUnit version to 9.6 (or 9.6.x)

@Chris53897
Copy link
ContributorAuthor

Bumping the minium PHPUnit version, solved this problem.
But of course this is up to you, to wait until PHPUnit 10+.

@Chris53897Chris53897force-pushed thefeature/fix-warning-for-tests branch fromd745584 to44cec07CompareSeptember 26, 2024 15:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chris53897@jbelien@Chris8934
[8]ページ先頭
©2009-2025 Movatter.jp