This repository was archived by the owner on Jun 6, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork360
Gh-3353: Ensure user info passed in GafferPop#3354
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedJan 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## develop #3354 +/- ##=============================================- Coverage 68.08% 68.06% -0.03% Complexity 2596 2596 ============================================= Files 957 957 Lines 30670 30674 +4 Branches 3399 3402 +3 =============================================- Hits 20881 20877 -4- Misses 8304 8313 +9+ Partials 1485 1484 -1 ☔ View full report in Codecov by Sentry. |
Uh oh!
There was an error while loading.Please reload this page.
rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/controller/GremlinController.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/handler/GremlinWebSocketHandler.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
p29876 previously approved these changesJan 20, 2025
cn337131 previously approved these changesJan 21, 2025
cn337131 approved these changesJan 21, 2025
p29876 approved these changesJan 21, 2025
07694ea intodevelop 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Addresses some of the issues with passing information from the REST API to gafferpop by ensuring each request now has its own instance of the tinkerpop graph layer so the variables are unique per request. Also stops the user from being reset immediately by the custom GraphStep.
Few other minor bits of tidying and improvements to otel logging.
Related issue