- Notifications
You must be signed in to change notification settings - Fork358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Gh-3322: Cache updates for federated POC#3323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## develop #3323 +/- ##=============================================+ Coverage 67.90% 67.95% +0.04%- Complexity 2596 2597 +1============================================= Files 953 955 +2 Lines 30498 30530 +32 Branches 3363 3369 +6 =============================================+ Hits 20710 20746 +36+ Misses 8312 8306 -6- Partials 1476 1478 +2 ☔ View full report in Codecov by Sentry. |
.../main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/EitherOperationHandler.javaShow resolvedHide resolved
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java OutdatedShow resolvedHide resolved
.../main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/EitherOperationHandler.javaShow resolvedHide resolved
...c/main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/SeparateOutputHandler.javaShow resolvedHide resolved
cn337131 previously approved these changesOct 21, 2024
p29876 previously approved these changesOct 22, 2024
p29876 previously approved these changesOct 22, 2024
cn337131 previously approved these changesOct 22, 2024
p29876 approved these changesOct 22, 2024
cn337131 approved these changesOct 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
enhancementImprovement to existing functionality/feature federated-storeSpecific to/touches the federated-store module
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few updates to how the federated store uses the cache. This allows users to specify a custom cache name for the graph cache which would enable sharing of graphs between federated stores.
This also addresses the handling of operations that technically could be handled by a federated store or by a sub graph. The overall logic has been simplified so that if an operation has graph IDs specified (or excluded) it will be assumed the operation should be run on those sub graphs.
This change has the added benefit of meaning mixing operations in the same chain e.g. for sub graphs or not, is handled seamlessly.
Related issue