- Notifications
You must be signed in to change notification settings - Fork358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Gh-3305: Fix to apply OpOptions at OpChain level#3306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## develop #3306 +/- ##=============================================+ Coverage 67.83% 67.84% +0.01% Complexity 2595 2595 ============================================= Files 951 951 Lines 30337 30353 +16 Branches 3342 3344 +2 =============================================+ Hits 20580 20594 +14- Misses 8291 8292 +1- Partials 1466 1467 +1 ☔ View full report in Codecov by Sentry. |
tb06904 approved these changesSep 27, 2024
wb36499 approved these changesSep 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teeny fix - applies operation options at opChain and operation level for simple fed store and current fed store.
Related issue