- Notifications
You must be signed in to change notification settings - Fork358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Gh-3292: REST API Gremlin Timeout and Execute Endpoints#3294
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear onthis overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check outthe documentation. |
| * @return A pair tuple with result and explain in. | ||
| */ | ||
| private Tuple2<Object, JSONObject> runGremlinQuery(final String gremlinQuery) { | ||
| LOGGER.info("QUERY IS: {} ", gremlinQuery); |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks
rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/controller/GremlinController.java FixedShow fixedHide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## develop #3294 +/- ##=============================================+ Coverage 67.76% 67.80% +0.04% Complexity 2594 2594 ============================================= Files 947 947 Lines 30217 30267 +50 Branches 3338 3338 =============================================+ Hits 20476 20524 +48- Misses 8274 8276 +2 Partials 1467 1467 ☔ View full report in Codecov by Sentry. |
Adds configurable timeout to the REST API for gremlin queries, also enables running queries via endpoints as well as the normal websocket. Few bits of tidying as well.
Related issue