- Notifications
You must be signed in to change notification settings - Fork358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Gh-3283: Remove Graph operation for Federated POC#3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## develop #3285 +/- ##=============================================+ Coverage 67.64% 67.66% +0.01%+ Complexity 2595 2594 -1============================================= Files 938 942 +4 Lines 30024 30070 +46 Branches 3321 3321 =============================================+ Hits 20311 20346 +35- Misses 8251 8262 +11 Partials 1462 1462 ☔ View full report in Codecov by Sentry. |
...main/java/uk/gov/gchq/gaffer/federated/simple/operation/handler/misc/RemoveGraphHandler.javaShow resolvedHide resolved
p29876 previously approved these changesSep 10, 2024
🔥 |
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java OutdatedShow resolvedHide resolved
…ov/gchq/gaffer/federated/simple/FederatedStore.javaCo-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>
cn337131 approved these changesSep 11, 2024
p29876 approved these changesSep 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a remove graph and get all graph IDs operation to the simple federated store. The remove graph can optionally delete all data or just de reference the graph.
Related issue