Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Introducing FitStatistic#5696

Open
registerrier wants to merge10 commits intogammapy:main
base:main
Choose a base branch
Loading
fromregisterrier:fit_statistic2

Conversation

registerrier
Copy link
Contributor

Description

This pull request proposes another/simpler version of FitStatistic as discussed with@adonath@QRemy@AtreyeeS@bkhelifi .
Allstat_sum andstat_array are now only on the baseDataset class.

Dear reviewer

@registerrierregisterrier added this to thewishlist milestoneFeb 6, 2025
@registerrierregisterrier marked this pull request as draftFebruary 6, 2025 22:11
@codecovCodecov
Copy link

codecovbot commentedFeb 6, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is91.40625% with11 lines in your changes missing coverage. Please review.

Project coverage is 94.65%. Comparing base(a007231) to head(8d1f043).
Report is 105 commits behind head on main.

Files with missing linesPatch %Lines
gammapy/stats/fit_statistics.py89.90%11 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #5696      +/-   ##==========================================+ Coverage   94.62%   94.65%   +0.03%==========================================  Files         239      239                Lines       37468    37652     +184     ==========================================+ Hits        35454    35640     +186+ Misses       2014     2012       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
@registerrierregisterrier marked this pull request as ready for reviewMarch 7, 2025 08:03
@registerrierregisterrier changed the title[PROTOYPE] Introducing FitStatistic: a different approachIntroducing FitStatistic: a different approachMar 7, 2025
@registerrierregisterrier changed the titleIntroducing FitStatistic: a different approachIntroducing FitStatisticMar 7, 2025
@registerrierregisterrier modified the milestones:wishlist,2.0Mar 7, 2025
@registerrier
Copy link
ContributorAuthor

Question from the dev call: how can one serialize thestat_type along theDataset?

Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
Copy link
Contributor

@QRemyQRemy left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@registerrier I have just few minor comment.

"cash": CashFitStatistic,
"wstat": WStatFitStatistic,
"chi2": Chi2FitStatistic,
"distrib": Chi2AsymmetricErrorFitStatistic,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

a follow up PR could rename distrib -> chi2asym

@registerrier
Copy link
ContributorAuthor

Hi@adonath . Do you have further comments on this PR?

Copy link
Member

@AtreyeeSAtreyeeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@registerrier ! No comments!
Maybe we can document later how to adapt the stat_type

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QRemyQRemyQRemy left review comments

@AtreyeeSAtreyeeSAtreyeeS approved these changes

@adonathadonathAwaiting requested review from adonath

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

3 participants
@registerrier@QRemy@AtreyeeS
[8]ページ先頭
©2009-2025 Movatter.jp