Commit982fcf5

authored and

committed

fix: #285 react-css-modules causes modifying key property of the component children (#286)

1 parent54b4367 commit982fcf5Copy full SHA for 982fcf5

File tree

+17

-1

lines changed

+17

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ const linkElement = (element: ReactElement, styles: Object, configuration: Objec`
`50`	`50`	`if(React.isValidElement(children)){`
`51`	`51`	`elementShallowCopy.props.children=linkElement(React.Children.only(children),styles,configuration);`
`52`	`52`	`}elseif(_.isArray(children)\|\|isIterable(children)){`
`53`		`-elementShallowCopy.props.children=React.Children.map(children,(node)=>{`
	`53`	`+elementShallowCopy.props.children=_.map(children,(node)=>{`
`54`	`54`	`if(React.isValidElement(node)){`
`55`	`55`	`// eslint-disable-next-line no-use-before-define`
`56`	`56`	`returnlinkElement(React.Children.only(node),styles,configuration);`

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,22 @@ describe('linkClass', () => {`
`141`	`141`	`expect(subject.props.children[0].props).not.to.have.property('styleName');`
`142`	`142`	`expect(subject.props.children[1].props).not.to.have.property('styleName');`
`143`	`143`	`});`
	`144`	`+it('preserves original keys',()=>{`
	`145`	`+letsubject;`
	`146`	`+`
	`147`	`+subject=<div>`
	`148`	`+<pkey='1'styleName='foo'/>`
	`149`	`+<pkey='2'styleName='bar'/>`
	`150`	`+</div>;`
	`151`	`+`
	`152`	`+subject=linkClass(subject,{`
	`153`	`+bar:'bar-1',`
	`154`	`+foo:'foo-1'`
	`155`	`+});`
	`156`	`+`
	`157`	`+expect(subject.props.children[0].key).to.equal('1');`
	`158`	`+expect(subject.props.children[1].key).to.equal('2');`
	`159`	`+});`
`144`	`160`	`});`
`145`	`161`	`context('when multiple descendants have styleName and are iterable',()=>{`
`146`	`162`	`it('assigns a generated className',()=>{`

Comments

(0)