- Notifications
You must be signed in to change notification settings - Fork1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
document the way to use gendex and dex.go for new GoNativeActivity.java behaviour#5387
base:master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FYI: We are planning on deprecating this tool here in favour of moving it intohttps://github.com/fyne-io/tools. I think I changed how the generation is done in that project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great additions thanks, but I think one of the docs is a bit misleading.
| @@ -27,6 +27,11 @@ | |||
| import android.widget.TextView; | |||
| import android.widget.TextView.OnEditorActionListener; | |||
| // GoNativeActivity is the java implementation that helps Go map to android via the NDK. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure this first sentence is right - the activity is the entry point for our Android boot loader.
The NDK connects to this via C - so it's not really providing any connections itself I don't think?...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What I meant (from my VERY limited understanding) is that it was the java SDK object that was a utility for Go to access via the C and the NDK.
I guess I don't know how to express it correctly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Go accesses the Java object via NDK. The Java provides us certain functionality which is accessed through JNI and C functionality.
Is that clearer?
Ok. What's the new procedure to generate a new dex, then? |
We are in the process of moving |
coveralls commentedJan 11, 2025
Yes, please. I've just done a merge, so we should be able to move ahead without too much delay:fyne-io/tools#24 |
Can you please file PR against the Fyne tools repo athttps://github.com/fyne-io/tools? That way you can also just file against the |
That reminds me, please note that PRs should go to the develop branch in this repository and that the PR template should be filled out accordingly, not removed. |
Thanks@Jacalz I missed that! |
So the So it's gonna base on the GoNativeActivity that would be referenced from the |
I already implementing the support for updating the Dex stuff in that repository. It relies on the cloned |
Yes it should work the same way, though perhaps we need to document the additional assumption that "tools" and "fyne" repos are checked out next to each other. |
Just so you know@dolanor we are tagging an alpha build of v2.6.0 today and the tools repo is ready to be the replacement for the internal tools. Possibly a good time to get this updated and landed too? |
No description provided.