- Notifications
You must be signed in to change notification settings - Fork22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fixed compatibility with composer 2.1#38
Conversation
dsturm commentedJun 14, 2021
Hej@SamMousa, shouldn't we check, whether version_compare(Composer::RUNTIME_API_VERSION,'2.0.0','>=') Or is there a reason to explicitly check for |
Use php native `version_compare()` to fix bug in current composer `2.1.3`
@SamMousa It is preferable to use |
I used strict comparison because that's what was done in original code. I'm fine updating it to use version compare |
Yes, please, you might as well improve the code immediately :-) |
Use `version_compare` instead of string comparison
@francoispluchino, the PR is done but CI is broken. |
Bump |
Thank you! |
Fixes#37