Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
/foxyPublic
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Fixed compatibility with composer 2.1#38

Merged
francoispluchino merged 2 commits intofxpio:masterfromSamMousa:patch-1
Jun 24, 2021
Merged

Fixed compatibility with composer 2.1#38

francoispluchino merged 2 commits intofxpio:masterfromSamMousa:patch-1
Jun 24, 2021

Conversation

SamMousa
Copy link
Contributor

Fixes#37

@dsturm
Copy link

Hej@SamMousa,

shouldn't we check, whetherComposer::RUNTIME_API_VERSION is at least2.0.0 and therefor use

version_compare(Composer::RUNTIME_API_VERSION,'2.0.0','>=')

Or is there a reason to explicitly check for2.0.0 and2.1.0?

dsturm added a commit to zirkeldesign/foxy that referenced this pull requestJun 14, 2021
Use php native `version_compare()` to fix bug in current composer `2.1.3`
@francoispluchino
Copy link
Member

@SamMousa It is preferable to useversion_compare function.

@SamMousa
Copy link
ContributorAuthor

I used strict comparison because that's what was done in original code. I'm fine updating it to use version compare

dsturm reacted with thumbs up emoji

@francoispluchino
Copy link
Member

Yes, please, you might as well improve the code immediately :-)

Use `version_compare` instead of string comparison
@SamMousa
Copy link
ContributorAuthor

@francoispluchino, the PR is done but CI is broken.

terabytesoftw and joester89 reacted with thumbs up emoji

@SamMousa
Copy link
ContributorAuthor

Bump

terabytesoftw reacted with thumbs up emoji

@francoispluchinofrancoispluchino merged commitc455b0c intofxpio:masterJun 24, 2021
@francoispluchino
Copy link
Member

Thank you!

terabytesoftw reacted with thumbs up emojidsturm reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@francoispluchinofrancoispluchinoAwaiting requested review from francoispluchino

Assignees

@SamMousaSamMousa

Labels
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Issues with composer 2.1
3 participants
@SamMousa@dsturm@francoispluchino

[8]ページ先頭

©2009-2025 Movatter.jp