- Notifications
You must be signed in to change notification settings - Fork211
Clearing session cookie in Android AdvancedWeView so user can logout from GoogleAccount#237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dylan-dinh wants to merge166 commits intofeature/androidChoose a base branch
base:feature/android
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Added maintainers note on README
Add Spotify auth provider
Use asynchronous execution for safariViewController
The safariViewController dispatch was occuring on another thread.This sometimes caused app crashes when the view was presented,in particular if the keyboard had been presented via a TextInput orother component. The resulting crash complained about_cachedSystemAnimationFence and the main thread. This has been withother React Native apps that load a viewController.Dispatching to present the viewController on the main thread fixes thisissue.
Fix error for redefinition of RCTMethodInfo
Fix: Duplicate RCTMethodInfo while building iOS app
Remove deprecated@OverRide
Dispatch safariViewController on main queue
* 'master' of github.com:fullstackreact/react-native-oauth: Fix build issue Dispatch safariViewController on main queue
Changed if/else statement to avoid React error.
Fixes for Java/GSON syntax exception and issue#142
Merge PR 121, fix user agent, fix full screen webview
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Clearing session cookies, so that when you RevokeAccess via HTTP request of the Google API + deauthorize via react-native-oauth method, you can actually logout the user from his Google Account when he wants to logout from your application as well.
Where
in react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java
TODO
Didn't check it out for iOS, I can go through iOS cookies if you validate this pull request. 👍