- Notifications
You must be signed in to change notification settings - Fork211
Fixed disallowed_useragent issue for Google authentication on Android#228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
martin-badin commentedDec 11, 2018
Hello, please merge this fix! |
ericchan3721 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Better using the user's actual UserAgent and replacewv from it instead of the hard coded onemWebView.getSettings().setUserAgentString(mWebView.getSettings().getUserAgentString().replace("; wv", ""));
Ref:https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html
P.S. I have open the PR for this issue, however this library seems no longer supported by the original author, you may consider using other OAuth RN library.
Closes#87
This sets the webview User-Agent header to solve the
disallowed_useragentissue for Google authentication on Android.