- Notifications
You must be signed in to change notification settings - Fork211
Handle OAuth responses as querystring as well as JSON on Android#171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
stuartlangridge wants to merge4 commits intofullstackreact:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
(x-www-form-urlencoded), not as JSON, so signing in breaks as perfullstackreact#165.Correct this by catching the JSON parse error and falling back toextracting the parameters we need from the token instead.
Merge in OAuthManager.h iOS fixes
SailingSteve added a commit to SailingSteve/react-native-oauth that referenced this pull requestOct 25, 2017
and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
SailingSteve added a commit to SailingSteve/react-native-oauth that referenced this pull requestOct 25, 2017
and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
SailingSteve added a commit to SailingSteve/react-native-oauth that referenced this pull requestOct 26, 2017
and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
shalin-jasani added a commit to shalin-jasani/react-native-oauth that referenced this pull requestSep 10, 2018
…ani/fullstackreact/react-native-oauth master branch (#1)* Addedfullstackreact#171and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m* Addedfullstackreact#171and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m* Addedfullstackreact#171and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m* Merge PR 121, fix user agent, fix full screen webview* Changed if/else statement to avoid React error.* Fix duplicate RCTMethodInfo import (facebook/react-native#15775) (zoontek/react-native-permissions#137)* Fix duplicate React library import error conflict w/certain pods* Pass back response headers over javascript bridge* Dispatch safariViewController on main queueThe safariViewController dispatch was occuring on another thread.This sometimes caused app crashes when the view was presented,in particular if the keyboard had been presented via a TextInput orother component. The resulting crash complained about_cachedSystemAnimationFence and the main thread. This has been withother React Native apps that load a viewController.Dispatching to present the viewController on the main thread fixes thisissue.* Fix build issue* Remove deprecated@OverRide* Fix: Duplicate RCTMethodInfo while building iOS app* Fix error for redefinition of RCTMethodInfo* Ignored dist/* 2.1.16* 2.1.17* 2.1.18
dionsake added a commit to dionsake/workspace-react-native-OAuth that referenced this pull requestJan 10, 2020
and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
dionsake added a commit to dionsake/workspace-react-native-OAuth that referenced this pull requestJan 10, 2020
and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
dionsake added a commit to dionsake/workspace-react-native-OAuth that referenced this pull requestJan 10, 2020
and my NSString *clientID fix, which might not be as good ashttps://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitter, for example, returns OAuth token data as a querystring (x-www-form-urlencoded), not as JSON, so signing in breaks as per#165.
Correct this by catching the JSON parse error and falling back to extracting the parameters we need from the token instead.