Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Open safariViewController from main thread#150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tqc wants to merge1 commit intofullstackreact:master
base:master
Choose a base branch
Loading
fromtqc:patch-2

Conversation

@tqc
Copy link
Contributor

@tqctqc commentedAug 28, 2017

Fixes a crash when immediately reopening the safari view.

joncursi, virae, and blakek reacted with thumbs up emoji
@hpinsley
Copy link

HI Tom. I think your pull request may be a fix for my problem.

2017-09-11 07:30:12.780 TimeTrackerMobile[17121:1727273] authorize ----> {    "access_token_url" = "https://github.com/login/oauth/access_token";    "api_url" = "https://api.github.com";    "app_name" = timetracker;    "auth_version" = "2.0";    "authorize_url" = "https://github.com/login/oauth/authorize";    "callback_url" = "timetracker://oauth";    "client_id" = e0...48;    "client_secret" = d2...b8;    scopes = email;} <DCTOAuth2Account: 0x60000033d880; type = github; identifier = B83AA7B7-F783-47EF-B038-533A7458D38F; credential = (null)>2017-09-11 07:30:59.290 TimeTrackerMobile[17121:1727228] *** Assertion failure in -[UIKeyboardTaskQueue waitUntilAllTasksAreFinished], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit_Sim/UIKit-3600.7.47/Keyboard/UIKeyboardTaskQueue.m:4322017-09-11 07:30:59.303 TimeTrackerMobile[17121:1727228] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '-[UIKeyboardTaskQueue waitUntilAllTasksAreFinished] may only be called from the main thread.'*** First throw call stack:(0   CoreFoundation                      0x0000000109b86b0b __exceptionPreprocess + 1711   libobjc.A.dylib                     0x0000000108a3c141 objc_exception_throw + 482   CoreFoundation                      0x0000000109b8acf2 +[NSException raise:format:arguments:] + 983   Foundation                          0x0000000106cbf536 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 1934   UIKit                               0x0000000107d13f6f -[UIKeyboardTaskQueue waitUntilAllTasksAreFinished] + 1655   UIKit                               0x0000000107494515 -[UIKeyboardImpl setDelegate:force:] + 13726   UIKit                               0x00000001078aa63d -[UIPeripheralHost(UIKitInternal) _reloadInputViewsForResponder:] + 9927   UIKit                               0x00000001078b3c4b -[UIPeripheralHost(UIKitInternal) _preserveInputViewsWithId:animated:reset:] + 4998   UIKit                               0x000000010738a35d -[UIViewController _presentViewController:modalSourceViewController:presentationController:animationController:interactionController:completion:] + 11459   UIKit                               0x000000010738bfae -[UIViewController _presentViewController:withAnimationController:completion:] + 466010  UIKit                               0x000000010738ee8a -[UIViewController _performCoordinatedPresentOrDismiss:animated:] + 53211  UIKit                               0x000000010738e962 -[UIViewController presentViewController:animated:completion:] + 18112  TimeTrackerMobile                   0x00000001061693d9 __34+[OAuthManager setupOAuthHandler:]_block_invoke + 28113  DCTAuth                             0x0000000106ba55bc -[DCTAuthPlatform openURL:completion:] + 25214  DCTAuth                             0x0000000106bab505 -[DCTAuthURLOpenerOperation start] + 18115  Foundation                          0x0000000106c295fc __NSOQSchedule_f + 19816  libdispatch.dylib                   0x000000010bfad05c _dispatch_client_callout + 817  libdispatch.dylib                   0x000000010bf8b94f _dispatch_queue_serial_drain + 22118  libdispatch.dylib                   0x000000010bf8c669 _dispatch_queue_invoke + 108419  libdispatch.dylib                   0x000000010bf8eec4 _dispatch_root_queue_drain + 63420  libdispatch.dylib                   0x000000010bf8ebef _dispatch_worker_thread3 + 12321  libsystem_pthread.dylib             0x000000010c3445a2 _pthread_wqthread + 129922  libsystem_pthread.dylib             0x000000010c34407d start_wqthread + 13)

Is there a related issue for this?

@joncursi
Copy link

I can confirm that this works for me! I wasscratching my head over this one!

@ArtisanalPickle
Copy link

Yea this one is pretty insidious; happens to me in my app about 50% of the time right now. Would love to see this get merged...

blakek added a commit to gsandf/react-native-oauth that referenced this pull requestJan 11, 2018
@blakek
Copy link

Can confirm this corrects a problem we were seeing with an app we have that opens the web view on a refresh.

To hopefully help anyone coming from a search engine, the error we were getting was:

accessing _cachedSystemAnimationFence requires the main thread ...

@johnyoonh
Copy link

Any plan to merge this in soon?

Copy link

@johnyoonhjohnyoonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This fix works and have been confirmed by other users in the thread.

@blakek
Copy link

@johnyoonh Our team forked this tohttps://github.com/gsandf/react-native-oauth because this repo seems inactive. We pulled this PR in and made a couple other fixes where this wasn't following theOAuth 2.0 spec, including:

  • scopes must be separated by spaces (section 3.3)
  • the client secret must not be sent in the request URI when fetching the access token (section 2.3.1)

We'd love to help get this working with OAuth 2.0 if this becomes active again.

selarom-epilef and ewanmellor reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@johnyoonhjohnyoonhjohnyoonh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tqc@hpinsley@joncursi@ArtisanalPickle@blakek@johnyoonh
[8]ページ先頭
©2009-2025 Movatter.jp