Added RemoteConfig API#145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Jeanmsilva89 wants to merge1 commit intofullstackreact:master

base:master

Choose a base branch

fromJeanmsilva89:feature/config

Open

Added RemoteConfig API#145

Jeanmsilva89 wants to merge1 commit intofullstackreact:masterfromJeanmsilva89:feature/config

Conversation

Copy link

Jeanmsilva89 commentedNov 18, 2016

Re-added RemoteConfig feature.

Added RemoteConfig API

a971038

Copy link

Contributor

mikelambert commentedNov 26, 2016

It seems configValueForKey only gets the stringValue of an item?

Before I discovered firestack, I had built out a firebase3 module myself for the remoteconfig and analytics stuff I had needed. If you're motivated to get this implemented, perhaps you'd be interested in stealing my remoteconfig code?

https://github.com/mikelambert/react-native-firebase3/blob/master/android/src/main/java/org/jall/reactnative/firebase/RNFIRRemoteConfig.java

https://github.com/mikelambert/react-native-firebase3/blob/master/ios/Firebase/RNFIRRemoteConfig.m

It definitely works in iOS, and I'm pretty sure it works in Android (my app is broken w.r.t. this right now, but I believe that's due to the recent inclusion of both rn-firestack and rn-firebase3 in my project, both trying to initialize fb under-the-hood)