Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: use vite testing#315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
a2937 wants to merge3 commits intofreeCodeCamp:main
base:main
Choose a base branch
Loading
froma2937:feat/use-vite-testing

Conversation

a2937
Copy link
Member

Checklist:

Closes#301

It's a pretty huge migration but it adds both Typescript to the main files and Vite.

@socket-securitySocket Security
Copy link

socket-securitybot commentedSep 12, 2024•
edited
Loading

New and removed dependencies detected. Learn more aboutSocket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@types/jest@29.5.13Transitive:environment,filesystem,unsafe+281.4 MBtypes
npm/@types/node@22.5.4None02.2 MBtypes
npm/@types/react-dom@18.3.0None037.8 kBtypes
npm/@types/react@18.3.5None+21.69 MBtypes
npm/@vitejs/plugin-react@4.3.1Transitive:environment+4411.5 MBvitebot
npm/cypress@13.14.2Transitive:environment,eval,filesystem,network,shell,unsafe+13020 MBastone123,atofstryker,brian-mann, ...9 more
npm/eventsource@2.0.2network0314 kBrexxars
npm/eventsourcemock@2.0.0None0183 kBgcedo
npm/happy-dom@15.7.4network,shell,unsafe+19.75 MBdavidortner
npm/jest-environment-jsdom@29.7.0Transitive:environment,eval,filesystem,network,shell,unsafe+638.03 MBsimenb
npm/jest@29.7.0Transitive:environment,eval,filesystem,network,shell,unsafe+24918.8 MBsimenb
npm/lint-staged@15.2.10Transitive:environment,filesystem,shell+492.18 MBokonet
npm/prettier@3.3.3environment,filesystem,unsafe07.7 MBprettier-bot
npm/react-device-detect@2.2.3None049.6 kBduskload
npm/react-dom@18.3.1environment+34.63 MBreact-bot
npm/react-page-visibility@7.0.0Transitive:environment+5184 kBpgilad
npm/react@18.3.1environment+2339 kBreact-bot

🚮 Removed packages:npm/cypress@13.15.1,npm/execa@9.5.1

View full report↗︎

@shootermv
Copy link

@a2937 are you still working on this PR? i wanted to ask something if you do...

@a2937
Copy link
MemberAuthor

a2937 commentedOct 29, 2024•
edited
Loading

@shootermv

What's the question?

Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.

@shootermv
Copy link

shootermv commentedOct 29, 2024 via email

How about also move from using create-react-app and move to use viteinstead?
…
On Tue, Oct 29, 2024, 14:36 Anna ***@***.***> wrote:@shootermv <https://github.com/shootermv> What's the question? Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help. — Reply to this email directly, view it on GitHub <#315 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKGMHWQ56I3C32QNQKQZ4LZ556MXAVCNFSM6AAAAABOEAB2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGA4DMOBYGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

@shootermv
Copy link

shootermv commentedOct 29, 2024 via email

What the netlify issues you facing?
…
On Tue, Oct 29, 2024, 14:45 Moshe Vilner ***@***.***> wrote: How about also move from using create-react-app and move to use vite instead? On Tue, Oct 29, 2024, 14:36 Anna ***@***.***> wrote:>@shootermv <https://github.com/shootermv>>> What's the question?>> Edit: I had gotten stuck on this PR due to Netlify issues. I am not> abandoning this PR. I just think I need a little help.>> —> Reply to this email directly, view it on GitHub> <#315 (comment)>,> or unsubscribe> <https://github.com/notifications/unsubscribe-auth/AAKGMHWQ56I3C32QNQKQZ4LZ556MXAVCNFSM6AAAAABOEAB2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGA4DMOBYGI>> .> You are receiving this because you were mentioned.Message ID:> ***@***.***>>

@a2937a2937force-pushed thefeat/use-vite-testing branch 2 times, most recently from57a7c42 tobacd2a1CompareOctober 29, 2024 13:23
@a2937
Copy link
MemberAuthor

a2937 commentedOct 29, 2024•
edited
Loading

How about also move from using create-react-app and move to use vite instead?

Except I did. I also needed Typescript. The netlify issues were updating the header rules and dealing the pages changed thing.

P.S Sorry about the next few pushes. The package.json is taking me by surprise.

@shootermv
Copy link

i can see something is wrong with cypress test for firefox - is running without finish

@a2937
Copy link
MemberAuthor

Remind me to update this to use Playwright after this PR gets merged.

shootermv reacted with thumbs up emoji

@shootermv
Copy link

i think i have idea about solve "endless cypress run" issue...
how about to run the cypress only on chrome?
you can use --browser flagcypress run --browser chrome
i know i is not ideal solution, to ignore ff, but anyway , the plan is to move to playwright...

@a2937
Copy link
MemberAuthor

I have a crazy idea but I think I know why it's continuing forever. It's trying to load in the ChatBot that is linked to the Discord server.

@a2937a2937force-pushed thefeat/use-vite-testing branch from3bc4c1c to8e671ffCompareNovember 1, 2024 19:01
@shootermv
Copy link

i changed thecypress command at package json "scripts" tocypress run --browser chrome & tested locally. it worked at my environment...
also it may be good idea to upgrade cypress to^13.15.1 version

@a2937a2937force-pushed thefeat/use-vite-testing branch from6d81c16 to6b9b277CompareNovember 5, 2024 16:14
@shootermv
Copy link

is there need to be improved at this pr?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@naomi-lgbtnaomi-lgbtnaomi-lgbt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider move the dev server to vite from deprecated CRA
3 participants
@a2937@shootermv@naomi-lgbt
[8]ページ先頭
©2009-2025 Movatter.jp