Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fixed bug in stringlist#552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
aman-godara wants to merge7 commits intofortran-lang:master
base:master
Choose a base branch
Loading
fromaman-godara:stringlist-bugfix

Conversation

aman-godara
Copy link
Member

If the insertedslist has length 0, theninsert_at can giveseg-fault error in this code:

do i= work_idxn+ post_length- pre_length, post_length         list%stringarray(inew)= slist%stringarray(i)         inew= inew+1end do

Resolved by: adding anif-else statement to check for length ofslist

jvdp1 reacted with thumbs up emoji
@aman-godara

This comment has been minimized.

@aman-godara

This comment has been minimized.

@aman-godara
Copy link
MemberAuthor

aman-godara commentedOct 15, 2021
edited
Loading

Any reason why test cases won't pass specifically formacos compiler. I rechecked everything many times but couldn't find any error in logic, I wanted to know if I am making some mistake by making some assumption which is invalid formacos's compiler.

PS: all test cases pass for mygfortran 10.2.0 windows, rancmake --build build --target clean as well.

@aman-godaraaman-godaraforce-pushed thestringlist-bugfix branch 5 times, most recently from7c04491 toc5ea35dCompareOctober 17, 2021 11:36
@aman-godara
Copy link
MemberAuthor

aman-godara commentedOct 17, 2021
edited
Loading

As per my analysis:

call number 14 to functioncompare_list is failing because:

work_list <-["-100", "-99", ..., "99", "100"] (201 items)

I am trying to insertwork_list at thehead ofwork_list, expecting an output:["-100", "-99", ..., "99", "100", "-100", "-99", ..., "99", "100"] (402 items).

This is what I am getting as the output frommacos compiler:["", "", ..., "", "", "-100", "-99", ..., "99", "100"] (402 items)

@jvdp1
Copy link
Member

What is the status of this PR? How can we help to move forward?

@aman-godara
Copy link
MemberAuthor

@jvdp1 Thanks for contacting. PR is stuck here, I tried many different things. I have mentioned the details of the problemhere.

I am planning to make these test cases readable for others (I should have thought to do that earlier).
But I don't understand why all test cases passes on my GCC compiler but not here on GitHub. This is also preventing me from diving deep into the issue because I have to make a commit everytime and push it to GitHub to see if it works or not. That's why you will see those "temp commits" in the logs.

@jvdp1
Copy link
Member

Strange...
I also testedthis commit bb30a55a53b3728232727a3afdce168900b0be66 using Fedora with GCC 11.2.0, and all tests passed.
I'll try to look further in the next days...

aman-godara reacted with thumbs up emoji

@aman-godara
Copy link
MemberAuthor

Any luck?@jvdp1

@jvdp1
Copy link
Member

Any luck?@jvdp1

No :( And then the holidays arrived. It is also difficult to run tests as I don't have a MacOS computer. Anyone with a MaCOS to test this issue?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aman-godara@jvdp1

[8]ページ先頭

©2009-2025 Movatter.jp