- Notifications
You must be signed in to change notification settings - Fork191
fixed bug in stringlist#552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aman-godara commentedOct 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Any reason why test cases won't pass specifically formacos compiler. I rechecked everything many times but couldn't find any error in logic, I wanted to know if I am making some mistake by making some assumption which is invalid formacos's compiler. PS: all test cases pass for mygfortran 10.2.0 windows, rancmake --build build --target clean as well. |
690c89a
to597ddbd
Compare7c04491
toc5ea35d
Compareaman-godara commentedOct 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
As per my analysis: call number 14 to functioncompare_list is failing because:
I am trying to insert This is what I am getting as the output frommacos compiler: |
c5ea35d
to0bd66e1
CompareWhat is the status of this PR? How can we help to move forward? |
@jvdp1 Thanks for contacting. PR is stuck here, I tried many different things. I have mentioned the details of the problemhere. I am planning to make these test cases readable for others (I should have thought to do that earlier). |
Strange... |
Any luck?@jvdp1 |
No :( And then the holidays arrived. It is also difficult to run tests as I don't have a MacOS computer. Anyone with a MaCOS to test this issue? |
If the inserted
slist
has length 0, theninsert_at
can giveseg-fault error in this code:Resolved by: adding anif-else statement to check for length of
slist