This repository was archived by the owner on Jun 8, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork119
Babel 7 upgrade#145
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Babel 7 upgrade#145
Changes fromall commits
Commits
Show all changes
7 commits Select commitHold shift + click to select a range
7106663 use upath for cross platform path testing
bj00rn9755796 upgrade to babel 7
bj00rne8a8949 babel 7 supports 6 and above
bj00rn0b6e0ac upgrade to release
bj00rnc92904c upgrade babel-plugin-espower
bj00rnccece78 semver ^7.0.0
bj00rndb0e9c9 deduplicate dependecies
bj00rnFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
6 changes: 3 additions & 3 deletions.babelrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "presets": [ | ||
| "@babel/preset-env" | ||
| ], | ||
| "plugins": [ | ||
| "@babel/plugin-proposal-object-rest-spread", | ||
| "@babel/plugin-transform-runtime" | ||
| ] | ||
| } |
2 changes: 0 additions & 2 deletions.travis.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| sudo:false | ||
| language:node_js | ||
| node_js: | ||
| -6 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think we should have testing on v8 and v10 right now. ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. seems a little out-of-scope for this, dont you think? maybe a separate PR for this? | ||
| before_install:if [[ `npm -v` != 3* ]]; then npm i -g npm@3; fi | ||
| script:npm run lint && npm test | ||
24 changes: 14 additions & 10 deletionspackage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionscripts/build-fixtures.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionssrc/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,7 +4,7 @@ | ||
| * See the accompanying LICENSE file for terms. | ||
| */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Issue seems to be here where upath is clearly used in library code, but not added to normal dependencies but only devDependencies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @serwer-WittGruppe want to test it out and open a PR with the fix? | ||
| import * as p from 'upath'; | ||
| import {writeFileSync} from 'fs'; | ||
| import {sync as mkdirpSync} from 'mkdirp'; | ||
| import printICUMessage from './print-icu-message'; | ||
| @@ -152,7 +152,7 @@ export default function ({types: t}) { | ||
| let loc; | ||
| if (opts.extractSourceLocation) { | ||
| loc = { | ||
| file: p.toUnix(p.relative(process.cwd(), file.opts.filename)), | ||
| ...path.node.loc, | ||
| }; | ||
| } | ||
4 changes: 2 additions & 2 deletionstest/fixtures/.babelrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "presets": [ | ||
| "@babel/preset-env", | ||
| "@babel/preset-react" | ||
| ], | ||
| "env": { | ||
| "test": { | ||
63 changes: 37 additions & 26 deletionstest/fixtures/FormattedHTMLMessage/expected.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,56 @@ | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { | ||
| value: true | ||
| }); | ||
| exports.default = void 0; | ||
| var_react =_interopRequireWildcard(require("react")); | ||
| var_reactIntl = require("react-intl"); | ||
| function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else {varnewObj ={}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj.default = obj; return newObj; } } | ||
| function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); } | ||
| function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } } | ||
| function _defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } | ||
| function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _defineProperties(Constructor.prototype, protoProps); if (staticProps) _defineProperties(Constructor, staticProps); return Constructor; } | ||
| function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) === "object" || typeof call === "function")) { return call; } return _assertThisInitialized(self); } | ||
| function _assertThisInitialized(self) { if (self === void 0) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return self; } | ||
| function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); } | ||
| function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function"); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, writable: true, configurable: true } }); if (superClass) _setPrototypeOf(subClass, superClass); } | ||
| function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); } | ||
| var Foo = | ||
| /*#__PURE__*/ | ||
| function (_Component) { | ||
| _inherits(Foo, _Component); | ||
| functionFoo() { | ||
| _classCallCheck(this, Foo); | ||
| return _possibleConstructorReturn(this, _getPrototypeOf(Foo).apply(this, arguments)); | ||
| } | ||
| _createClass(Foo, [{ | ||
| key: "render", | ||
| value: function render() { | ||
| return _react.default.createElement(_reactIntl.FormattedHTMLMessage, { | ||
| id: "foo.bar.baz", | ||
| defaultMessage: "<h1>Hello World!</h1>" | ||
| }); | ||
| } | ||
| }]); | ||
| return Foo; | ||
| }(_react.Component); | ||
| exports.default = Foo; |
63 changes: 37 additions & 26 deletionstest/fixtures/FormattedMessage/expected.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,56 @@ | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { | ||
| value: true | ||
| }); | ||
| exports.default = void 0; | ||
| var_react =_interopRequireWildcard(require("react")); | ||
| var_reactIntl = require("react-intl"); | ||
| function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else {varnewObj ={}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj.default = obj; return newObj; } } | ||
| function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); } | ||
| function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } } | ||
| function _defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } | ||
| function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _defineProperties(Constructor.prototype, protoProps); if (staticProps) _defineProperties(Constructor, staticProps); return Constructor; } | ||
| function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) === "object" || typeof call === "function")) { return call; } return _assertThisInitialized(self); } | ||
| function _assertThisInitialized(self) { if (self === void 0) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return self; } | ||
| function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); } | ||
| function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function"); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, writable: true, configurable: true } }); if (superClass) _setPrototypeOf(subClass, superClass); } | ||
| function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); } | ||
| var Foo = | ||
| /*#__PURE__*/ | ||
| function (_Component) { | ||
| _inherits(Foo, _Component); | ||
| functionFoo() { | ||
| _classCallCheck(this, Foo); | ||
| return _possibleConstructorReturn(this, _getPrototypeOf(Foo).apply(this, arguments)); | ||
| } | ||
| _createClass(Foo, [{ | ||
| key: "render", | ||
| value: function render() { | ||
| return _react.default.createElement(_reactIntl.FormattedMessage, { | ||
| id: "foo.bar.baz", | ||
| defaultMessage: "Hello World!" | ||
| }); | ||
| } | ||
| }]); | ||
| return Foo; | ||
| }(_react.Component); | ||
| exports.default = Foo; |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.