- Notifications
You must be signed in to change notification settings - Fork119
Babel 7 upgrade#145
Babel 7 upgrade#145
Uh oh!
There was an error while loading.Please reload this page.
Conversation
https://github.com/yahoo/babel-plugin-react-intl/blob/v2.4.0/.travis.yml#L4-L5 Babel v7 is no longer supported under Node.js v5. |
@ykzts 👍 |
| ...BASE_OPTIONS, | ||
| ...options, | ||
| }]; | ||
| },uuidv1()]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
somewhat dirty fix, need to add random string suffix to allow plugin to run more than once
tstirrat15 commentedAug 29, 2018
Two things: one is that Babel 7.0.0 (i.e. non-beta) is out. Is it worth upgrading directly to that? The other is that I'd love to see this work go through. What's the status? Is there any way that I can help it along? |
@tstirrat15 moved to 7.0 |
@ericf what are the chances of having this merged? |
| node_js: | ||
| -4.2 | ||
| -5 | ||
| -6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we should have testing on v8 and v10 right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
seems a little out-of-scope for this, dont you think? maybe a separate PR for this?
package.json Outdated
| "author":"Eric Ferraiuolo <edf@ericf.me>", | ||
| "dependencies": { | ||
| "babel-runtime":"^6.2.0", | ||
| "@babel/runtime":"7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why it's not semver style like^7.0.0? any concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed. thanks
didn't notice. i just ran babel-upgradehttps://github.com/babel/babel-upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm ok with this. We are going to need to release this as a major version bump.
@okuryu once you approve, we can merge and release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
I just published |
| * See the accompanying LICENSE file for terms. | ||
| */ | ||
| import*aspfrom'path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Issue seems to be here where upath is clearly used in library code, but not added to normal dependencies but only devDependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@serwer-WittGruppe want to test it out and open a PR with the fix?
Uh oh!
There was an error while loading.Please reload this page.
Upgrade to Babel 7
Resolves:#146#132#122