Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

36 feat switch from pyinvoke to just#42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fmind merged 2 commits intov4.0.0from36-feat-switch-from-pyinvoke-to-just
Mar 4, 2025

Conversation

@fmind
Copy link
Owner

Closes#36

@fmindfmind added featA new feature. Correlates with MINOR in SemVer breakingA breaking change. Correlates with MAJOR in SemVer labelsMar 4, 2025
@fmindfmind added this to thev4.0.0 milestoneMar 4, 2025
@fmindfmind self-assigned thisMar 4, 2025
Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello@fmind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue#36 by switching the task management system frompyinvoke tojust. This involves removinginvoke and introducingjust for defining and running project tasks. The changes include updating the GitHub Actions workflows, pre-commit configuration, README,pyproject.toml, and task definitions to reflect this transition.

Highlights

  • Task Management System Migration: Replacespyinvoke withjust for task automation, aiming for a simpler and more straightforward task definition.
  • GitHub Actions Workflow Updates: Modifies the CI/CD workflows (check.yml,publish.yml) to usejust commands instead ofinvoke.
  • Pre-commit Configuration: Updates.pre-commit-config.yaml to includebandit and upgrades the revisions ofpre-commit-hooks andcommitizen.
  • README Modifications: Updates the README to reflect the change frompyinvoke tojust, including updated command examples and task descriptions.
  • Dependency Management: Removesinvoke and addsrust-just as a development dependency inpyproject.toml. Also, addshatchling as a dependency.
  • Task Definition Restructuring: Replaces theinvoke.yaml andtasks/*.py files with a singlejustfile that defines all project tasks.

Changelog

Click here to see the changelog
  • .github/actions/setup/action.yml
    • Updates thesetup-uv action version fromv4 tov5.
  • .github/workflows/check.yml
    • Replacesinvoke commands withjust commands for running checks (format, type, code, security, coverage).
    • Changes theuv sync group fromchecks tocheck.
  • .github/workflows/publish.yml
    • Replacesinvoke commands withjust commands for documentation and package building.
    • Changes theuv sync group fromdocs todoc.
  • .pre-commit-config.yaml
    • Updates the revision ofpre-commit-hooks tov5.0.0.
    • Addsbandit hook for security checks.
    • Updates the revision ofcommitizen tov4.4.1.
  • README.md
    • Updates references fromPyInvoke toJust in the Automation section.
    • ReplacesPyenv withUv in the Programming section.
    • Updates command examples to usejust instead ofinv.
    • Replaces the list of available tasks with a TOML-style configuration example forjust.
    • Updates descriptions and alternatives for task automation.
  • invoke.yaml
    • Removes theinvoke.yaml file asinvoke is no longer used.
  • justfile
    • Adds ajustfile to define project tasks usingjust syntax, including tasks for checking, cleaning, committing, documenting, containerizing, formatting, installing, managing MLflow, packaging, and project management.
  • mlops-python-package.code-workspace
    • Removes thevsc-invoke extension recommendation.
  • pyproject.toml
    • Moveslicense andkeywords to be beforerequires-python.
    • Addshatchling as a dependency.
    • Renames dependency groupchecks tocheck.
    • Replacesinvoke withrust-just in thedev dependency group.
    • Renames dependency groupdocs todoc.
    • Renames dependency groupnotebooks tonotebook.
    • Updatesdefault-groups intool.uv to reflect the dependency group renames.
  • python_env.yaml
    • Removes thepython_env.yaml file.
  • requirements.txt
    • Removes therequirements.txt file.
  • tasks/init.py
    • Removes thetasks/__init__.py file.
  • tasks/check.just
    • Adds atasks/check.just file.
  • tasks/checks.py
    • Removes thetasks/checks.py file.
  • tasks/clean.just
    • Adds atasks/clean.just file.
  • tasks/cleans.py
    • Removes thetasks/cleans.py file.
  • tasks/commit.just
    • Adds atasks/commit.just file.
  • tasks/commits.py
    • Removes thetasks/commits.py file.
  • tasks/containers.py
    • Removes thetasks/containers.py file.
  • tasks/doc.just
    • Adds atasks/doc.just file.
  • tasks/docker.just
    • Adds atasks/docker.just file.
  • tasks/docs.py
    • Removes thetasks/docs.py file.
  • tasks/format.just
    • Adds atasks/format.just file.
  • tasks/formats.py
    • Removes thetasks/formats.py file.
  • tasks/install.just
    • Adds atasks/install.just file.
  • tasks/installs.py
    • Removes thetasks/installs.py file.
  • tasks/mlflow.just
    • Adds atasks/mlflow.just file.
  • tasks/mlflow.py
    • Removes thetasks/mlflow.py file.
  • tasks/package.just
    • Adds atasks/package.just file.
  • tasks/packages.py
    • Removes thetasks/packages.py file.
  • tasks/project.just
    • Adds atasks/project.just file.
  • tasks/projects.py
    • Removes thetasks/projects.py file.
  • uv.lock
    • Updates theuv.lock file to reflect the changes in dependencies, including the removal ofinvoke and the addition ofrust-just andhatchling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in issue comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.


Did you know?

Thejust command runner is written in Rust, a systems programming language known for its speed, safety, and concurrency.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request introduces significant improvements to the project, including updating the Python version, transitioning fromPyInvoke toJust for task management, updating dependencies, and enhancing data validation in core models. The changes are well-structured and contribute to the project's maintainability, efficiency, and reliability.

Summary of Findings

  • Python Version Updates: The pull request updates the Python version from 3.12 to 3.13 across multiple files, ensuring the project uses the latest features and improvements. This is a good practice for maintaining the project's currency and compatibility.
  • Dependency Updates: The pull request updates various dependencies inpyproject.toml to their latest versions, ensuring the project benefits from the latest features, bug fixes, and security patches. This is crucial for maintaining the project's stability and security.
  • Transition from PyInvoke to Just: The pull request transitions the project's task management fromPyInvoke toJust, which offers a more straightforward and efficient syntax for defining and executing tasks. This simplifies the project's automation and improves developer experience.
  • Removal ofpython_env.yaml andrequirements.txt: The pull request removes thepython_env.yaml andrequirements.txt files, relying instead onuv andpyproject.toml for managing dependencies. This streamlines the project's dependency management and reduces redundancy.
  • Improved Error Handling inAlertsService: The pull request improves error handling in theAlertsService by printing a message to the console when notifications are not supported, rather than raising a warning. This provides a more user-friendly experience.
  • Data Validation in Core Models: The pull request introduces data validation usingpandera schemas in the core models, ensuring data integrity and preventing unexpected errors. This enhances the project's robustness and reliability.

Merge Readiness

The pull request is in good shape to be merged. The changes are well-structured and contribute to the project's maintainability, efficiency, and reliability. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@fmindfmind merged commit22a0380 intov4.0.0Mar 4, 2025
1 check passed
@fmindfmind deleted the 36-feat-switch-from-pyinvoke-to-just branchMarch 4, 2025 20:10
fmind added a commit that referenced this pull requestMar 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fmindfmind

Labels

breakingA breaking change. Correlates with MAJOR in SemVerfeatA new feature. Correlates with MINOR in SemVer

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fmind

[8]ページ先頭

©2009-2025 Movatter.jp