- Notifications
You must be signed in to change notification settings - Fork3.4k
[Developer Draft] Add docs to support content resizing on iOS#12810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Summary of ChangesHello@LouiseHsu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the iOS 'add-to-app' documentation by providing comprehensive guidance on implementing dynamic content resizing for embedded Flutter views. It outlines the necessary steps to enable this feature, details the limitations concerning certain Flutter widgets, and offers practical code examples and a sample project to assist developers in integrating Flutter content that can adapt its size dynamically within an iOS application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
flutter-website-bot commentedDec 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Visit the preview URL for this PR (updated for commit12a618b): https://flutter-docs-prod--pr12810-content-resizing-ha8g1duf.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This PR adds documentation for supporting content resizing on iOS in add-to-app scenarios. The changes are clear and provide useful code snippets for Swift, Objective-C, and Dart. I've made a few suggestions to improve grammar, ensure consistency between code examples, and adhere to the Google Developer Documentation Style Guide.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
gemini suggestionCo-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
sfshaza2 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, once some nits are addressed.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
sfshaza2 commentedDec 15, 2025
@LouiseHsu, can you add this to the index file? Then it can land. |
sfshaza2 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixing a couple typos in the URLs.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
sfshaza2 commentedDec 15, 2025
Land once the page is added to the index file. |
Uh oh!
There was an error while loading.Please reload this page.
This pr adds some docs to support dynamic content resizing for add to app scenarios.
flutter/flutter#177410
This should land after Jan 14, since the feature landed on Dec 2, according tohttps://sites.google.com/corp/google.com/dash/operations-hub/releases
Presubmit checklist
of 80 characters or fewer.