This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Implement Android WebView api with pigeon (Java portion)#4441
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
a9b6fa2 java portion
bparrishMinesa4e919c add instance manager
bparrishMines2fbd130 change method name
bparrishMines8fe8aa6 add longsparsearray cheat
bparrishMines0086300 add web chrome client
bparrishMinesf5815bb Merge branch 'master' of github.com:flutter/plugins into webview_pige…
bparrishMinesFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
java portion
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita9b6fa2db8ca3fff8c547c29d2c07077ed921dfd
There are no files selected for viewing
4 changes: 4 additions & 0 deletionspackages/webview_flutter/webview_flutter_android/android/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions.../android/src/main/java/io/flutter/plugins/webviewflutter/DownloadListenerHostApiImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
| package io.flutter.plugins.webviewflutter; | ||
| import android.webkit.DownloadListener; | ||
| import io.flutter.plugins.webviewflutter.GeneratedAndroidWebView.DownloadListenerFlutterApi; | ||
| class DownloadListenerHostApiImpl implements GeneratedAndroidWebView.DownloadListenerHostApi { | ||
| private final InstanceManager instanceManager; | ||
| private final DownloadListenerCreator downloadListenerCreator; | ||
| private final GeneratedAndroidWebView.DownloadListenerFlutterApi downloadListenerFlutterApi; | ||
| static class DownloadListenerCreator { | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Creator inner classes are used to make it easier to test constructors | ||
| DownloadListener createDownloadListener( | ||
| Long instanceId, DownloadListenerFlutterApi downloadListenerFlutterApi) { | ||
| return (url, userAgent, contentDisposition, mimetype, contentLength) -> | ||
| downloadListenerFlutterApi.onDownloadStart( | ||
| instanceId, url, userAgent, contentDisposition, mimetype, contentLength, reply -> {}); | ||
| } | ||
| } | ||
| DownloadListenerHostApiImpl( | ||
| InstanceManager instanceManager, | ||
| DownloadListenerCreator downloadListenerCreator, | ||
| DownloadListenerFlutterApi downloadListenerFlutterApi) { | ||
| this.instanceManager = instanceManager; | ||
| this.downloadListenerCreator = downloadListenerCreator; | ||
| this.downloadListenerFlutterApi = downloadListenerFlutterApi; | ||
| } | ||
| @Override | ||
| public void create(Long instanceId) { | ||
| final DownloadListener downloadListener = | ||
| downloadListenerCreator.createDownloadListener(instanceId, downloadListenerFlutterApi); | ||
| instanceManager.addInstance(downloadListener, instanceId); | ||
| } | ||
| @Override | ||
| public void dispose(Long instanceId) { | ||
| instanceManager.removeInstanceId(instanceId); | ||
| } | ||
| } | ||
2 changes: 1 addition & 1 deletion...android/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebViewClient.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.