This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Implement Android WebView api with pigeon (Java portion)#4441
Merged
bparrishMines merged 6 commits intoflutter:masterfromOct 27, 2021
Merged
Implement Android WebView api with pigeon (Java portion)#4441bparrishMines merged 6 commits intoflutter:masterfrom
bparrishMines merged 6 commits intoflutter:masterfrom
Conversation
| private final DownloadListenerCreator downloadListenerCreator; | ||
| private final GeneratedAndroidWebView.DownloadListenerFlutterApi downloadListenerFlutterApi; | ||
| static class DownloadListenerCreator { |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Creator inner classes are used to make it easier to test constructors
mvanbeusekom suggested changesOct 21, 2021
Contributor
mvanbeusekom left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Two suggestions that might be interesting.
...flutter_android/android/src/main/java/io/flutter/plugins/webviewflutter/InstanceManager.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...flutter_android/android/src/main/java/io/flutter/plugins/webviewflutter/InstanceManager.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
mvanbeusekom approved these changesOct 26, 2021
Contributor
mvanbeusekom left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
blasten commentedOct 27, 2021
@camsim99 I thought this PR could interest you :P |
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestOct 27, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull requestOct 27, 2021
* master: Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442)
NickalasB added a commit to NickalasB/plugins that referenced this pull requestOct 27, 2021
* master: Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442)
hofmannfelix pushed a commit to hofmannfelix/plugins that referenced this pull requestOct 30, 2021
…ideo_src_on_same_controller* commit '76e84c0679dbab7bfaaaa553b17bb0dbdb9a3c33': (537 commits) [video_player] Initialize player when size and duration become available (flutter#4438) [webview_flutter] Implement zoom enabled for ios and android (flutter#4417) Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453) Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442) [webview] Fix typos in the README (flutter#4249) [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180) [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429) [shared_preferences] Switch to new analysis options (flutter#4384) [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413) [camera] Run iOS methods on UI thread by default (flutter#4140) [ci] Always run all `format` steps (flutter#4427) [flutter_plugin_tools] Fix license-check on Windows (flutter#4425) [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400) [image_picker][android] suppress unchecked warning (flutter#4408) ...# Conflicts:#packages/video_player/video_player/pubspec.yaml#packages/video_player/video_player_web/lib/video_player_web.dart#packages/video_player/video_player_web/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull requestDec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull requestDec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Implements theAndroid WebView library that is currently supported with pigeon.
Generated Code:
packages/webview_flutter/webview_flutter_android/android/src/main/java/io/flutter/plugins/webviewflutter/GeneratedAndroidWebView.javaJava side of#4435
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.