Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[flutter_plugin_android_lifecycle] remove placeholder dart file#4413

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
balvinderz:remove_dart_file
Oct 20, 2021
Merged

[flutter_plugin_android_lifecycle] remove placeholder dart file#4413
fluttergithubbot merged 3 commits intoflutter:masterfrom
balvinderz:remove_dart_file

Conversation

@balvinderz
Copy link
Contributor

@balvinderzbalvinderz commentedOct 4, 2021
edited
Loading

Removed empty placeholder dart file.

flutter/flutter#90983

Pre-launch Checklist

  • I read theContributor Guide and followed the process outlined there for submitting PRs.
  • I read theTree Hygiene wiki page, which explains my responsibilities.
  • I read and followed therelevant style guides and ranthe auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does usedart format.)
  • I signed theCLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.[shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • Iupdated pubspec.yaml with an appropriate new version according to thepub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

Copy link
Contributor

@stuartmorgan-gstuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@blasten for second review.

@stuartmorgan-gstuartmorgan-g added waiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. and removed last mile labelsOct 20, 2021
@balvinderz
Copy link
ContributorAuthor

I've rebased this branch with the latest master.

@fluttergithubbotfluttergithubbot merged commitcdbd62b intoflutter:masterOct 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestOct 20, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull requestOct 21, 2021
* master:  [webview] Fix typos in the README (flutter#4249)  [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180)  [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429)  [shared_preferences] Switch to new analysis options (flutter#4384)  [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413)  [camera] Run iOS methods on UI thread by default (flutter#4140)  [ci] Always run all `format` steps (flutter#4427)  [flutter_plugin_tools] Fix license-check on Windows (flutter#4425)  [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400)  [image_picker][android] suppress unchecked warning (flutter#4408)  [ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (flutter#4436)  [image_picker_for_web] Added support for maxWidth, maxHeight and imageQuality  (flutter#4389)  Bump compileSdkVersion to 31 (flutter#4432)  [camera] Update [CameraOrientationTests testOrientationNotifications] unit test to work on Xcode 13 (flutter#4426)  Update integration_test README  (flutter#3824)  [webview_flutter] Adjust test URLs again (flutter#4407)  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)  [camera] Add filter for unsupported cameras on Android (flutter#4418)
NickalasB added a commit to NickalasB/plugins that referenced this pull requestOct 21, 2021
* master:  [webview] Fix typos in the README (flutter#4249)  [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180)  [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429)  [shared_preferences] Switch to new analysis options (flutter#4384)  [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413)  [camera] Run iOS methods on UI thread by default (flutter#4140)  [ci] Always run all `format` steps (flutter#4427)  [flutter_plugin_tools] Fix license-check on Windows (flutter#4425)  [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400)  [image_picker][android] suppress unchecked warning (flutter#4408)  [ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (flutter#4436)  [image_picker_for_web] Added support for maxWidth, maxHeight and imageQuality  (flutter#4389)  Bump compileSdkVersion to 31 (flutter#4432)  [camera] Update [CameraOrientationTests testOrientationNotifications] unit test to work on Xcode 13 (flutter#4426)  Update integration_test README  (flutter#3824)  [webview_flutter] Adjust test URLs again (flutter#4407)  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)  [camera] Add filter for unsupported cameras on Android (flutter#4418)# Conflicts:#packages/webview_flutter/webview_flutter/CHANGELOG.md#packages/webview_flutter/webview_flutter/pubspec.yaml
yasargil added a commit to yasargil/plugins that referenced this pull requestOct 25, 2021
* master: (364 commits)  Use OpenJDK 11 in CI jobs  (flutter#4419)  [google_sign_in] remove the commented out code in tests (flutter#4442)  [webview] Fix typos in the README (flutter#4249)  [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180)  [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429)  [shared_preferences] Switch to new analysis options (flutter#4384)  [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413)  [camera] Run iOS methods on UI thread by default (flutter#4140)  [ci] Always run all `format` steps (flutter#4427)  [flutter_plugin_tools] Fix license-check on Windows (flutter#4425)  [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400)  [image_picker][android] suppress unchecked warning (flutter#4408)  [ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (flutter#4436)  [image_picker_for_web] Added support for maxWidth, maxHeight and imageQuality  (flutter#4389)  Bump compileSdkVersion to 31 (flutter#4432)  [camera] Update [CameraOrientationTests testOrientationNotifications] unit test to work on Xcode 13 (flutter#4426)  Update integration_test README  (flutter#3824)  [webview_flutter] Adjust test URLs again (flutter#4407)  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)  [camera] Add filter for unsupported cameras on Android (flutter#4418)  ...# Conflicts:#packages/google_maps_flutter/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
hofmannfelix pushed a commit to hofmannfelix/plugins that referenced this pull requestOct 30, 2021
…ideo_src_on_same_controller* commit '76e84c0679dbab7bfaaaa553b17bb0dbdb9a3c33': (537 commits)  [video_player] Initialize player when size and duration become available (flutter#4438)  [webview_flutter] Implement zoom enabled for ios and android (flutter#4417)  Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453)  Implement Android WebView api with pigeon (Java portion) (flutter#4441)  [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434)  Implement Android WebView api with pigeon (Dart portion)  (flutter#4435)  upgraded usage of BinaryMessenger (flutter#4451)  [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428)  Use OpenJDK 11 in CI jobs  (flutter#4419)  [google_sign_in] remove the commented out code in tests (flutter#4442)  [webview] Fix typos in the README (flutter#4249)  [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180)  [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429)  [shared_preferences] Switch to new analysis options (flutter#4384)  [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413)  [camera] Run iOS methods on UI thread by default (flutter#4140)  [ci] Always run all `format` steps (flutter#4427)  [flutter_plugin_tools] Fix license-check on Windows (flutter#4425)  [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400)  [image_picker][android] suppress unchecked warning (flutter#4408)  ...# Conflicts:#packages/video_player/video_player/pubspec.yaml#packages/video_player/video_player_web/lib/video_player_web.dart#packages/video_player/video_player_web/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull requestDec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull requestDec 21, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

@blastenblastenblasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesp: flutter_plugin_android_lifecyclewaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@balvinderz@stuartmorgan-g@blasten@fluttergithubbot

Comments


[8]ページ先頭

©2009-2026 Movatter.jp