Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[webview_flutter] Fixed todos in FlutterWebView.java#4394

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
amanv8060:90939
Sep 29, 2021
Merged

[webview_flutter] Fixed todos in FlutterWebView.java#4394
fluttergithubbot merged 3 commits intoflutter:masterfrom
amanv8060:90939

Conversation

@amanv8060
Copy link
Contributor

@amanv8060amanv8060 commentedSep 29, 2021
edited
Loading

Added the Overrides since the pr on which it was depending has landed to stable

List which issues are fixed by this PR.

#90939

If you had to change anything in theflutter/tests repo, include a link to the migration guide as per thebreaking change policy.

Pre-launch Checklist

  • I read theContributor Guide and followed the process outlined there for submitting PRs.
  • I read theTree Hygiene wiki page, which explains my responsibilities.
  • I read and followed therelevant style guides and ranthe auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does usedart format.)
  • I signed theCLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.[shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • Iupdated pubspec.yaml with an appropriate new version according to thepub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

@github-actionsgithub-actionsbot added p: webview_flutterEdits files for a webview_flutter plugin platform-android labelsSep 29, 2021
Copy link
Contributor

@stuartmorgan-gstuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@stuartmorgan-gstuartmorgan-g added the waiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labelSep 29, 2021
@fluttergithubbotfluttergithubbot merged commita1304ef intoflutter:masterSep 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 29, 2021
@amanv8060amanv8060 deleted the 90939 branchSeptember 30, 2021 19:45
NickalasB added a commit to NickalasB/plugins that referenced this pull requestSep 30, 2021
* master:  [google_maps_flutter] Add Marker drag events (flutter#2838)  [flutter_plugin_tools] Validate pubspec description (flutter#4396)  Add file_selector to the repo list (flutter#4395)  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)  [google_maps_flutter_web] Add Marker drag events (flutter#4385)  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)  Handle restored purchases in iOS example app (flutter#4392)  [file_selector] Remove custom analysis options (flutter#4382)  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)  Fixed _CastError when running example App (flutter#4390)  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)  Load navigation controls immediately. (flutter#4377)  [camera] Fix IllegalStateException being thrown in Android implementation when switching activities. (flutter#4319)# Conflicts:#packages/webview_flutter/webview_flutter/CHANGELOG.md#packages/webview_flutter/webview_flutter_android/CHANGELOG.md
mgonzalezc pushed a commit to mgonzalezc/plugins that referenced this pull requestOct 12, 2021
* master: (1126 commits)  [webview_flutter] Adjust test URLs again (flutter#4407)  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)  [camera] Add filter for unsupported cameras on Android (flutter#4418)  [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401)  [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404)  [ci] Remove obsolete Dockerfile (flutter#4405)  Fix order-dependant platform interface tests (flutter#4406)  [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)  [google_maps_flutter] Add Marker drag events (flutter#2838)  [flutter_plugin_tools] Validate pubspec description (flutter#4396)  Add file_selector to the repo list (flutter#4395)  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)  [google_maps_flutter_web] Add Marker drag events (flutter#4385)  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)  Handle restored purchases in iOS example app (flutter#4392)  [file_selector] Remove custom analysis options (flutter#4382)  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)  Fixed _CastError when running example App (flutter#4390)  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)  ...# Conflicts:#packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
amantoux pushed a commit to amantoux/plugins that referenced this pull requestDec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull requestDec 21, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesp: webview_flutterEdits files for a webview_flutter pluginplatform-androidwaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amanv8060@stuartmorgan-g@fluttergithubbot

Comments


[8]ページ先頭

©2009-2026 Movatter.jp