- Notifications
You must be signed in to change notification settings - Fork9.7k
[google_maps_flutter]: LatLng longitude loses precision in constructor #90574#4374
Conversation
…s already within range to avoid unnecessary precision loss
…s already within range to avoid unnecessary precision loss
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝Please visithttps://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️Googlers:Go here for more info. |
Murray-Meller commentedSep 23, 2021
@googlebot I signed it! |
All (the pull request submitter and all commit authors) CLAs are signed,but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️Googlers:Go here for more info. |
MurrayMeller commentedSep 23, 2021
@googlebot I consent. |
stuartmorgan-g left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Two minor comment nits, but otherwise looks great. Thanks for all the added test coverage!
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/location.dart OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...ges/google_maps_flutter/google_maps_flutter_platform_interface/test/types/location_test.dart OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…ion coming into the implementation
5921df3 toa69321eCompareMurray-Meller commentedSep 23, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the review,@stuartmorgan. I have addressed both your comments. I was wondering if you'd be able to help me understand more about my pipeline failures, where I could look and what I could do to get them fixed? Incase it changes, these checks were failing:
|
ditman commentedSep 24, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I can explain:
|
stuartmorgan-g left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
stuartmorgan-g commentedOct 1, 2021
Adding@ditman for secondary review per Flutter policy. |
ditman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
* master: [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404) [ci] Remove obsolete Dockerfile (flutter#4405) Fix order-dependant platform interface tests (flutter#4406) [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)
MurrayMeller commentedOct 5, 2021
Thanks@stuartmorgan &@ditman. One last question if I may, what is the timeline/process for this making it into a plugin release? |
ditman commentedOct 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@MurrayMeller For each push to When all the "Cirrus CI" tests pass, the "Release" action gets triggered, and if that's successful, it's already available to people: (A |
MurrayMeller commentedOct 6, 2021
Thank again,@ditman. Much appreciated. |
ditman commentedOct 6, 2021
@MurrayMeller thanks again for your contribution!! Keep them coming! |
* master: (1126 commits) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418) [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401) [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404) [ci] Remove obsolete Dockerfile (flutter#4405) Fix order-dependant platform interface tests (flutter#4406) [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374) [google_maps_flutter] Add Marker drag events (flutter#2838) [flutter_plugin_tools] Validate pubspec description (flutter#4396) Add file_selector to the repo list (flutter#4395) [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363) [google_maps_flutter_web] Add Marker drag events (flutter#4385) [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394) Handle `PurchaseStatus.restored` correctly in example. (flutter#4393) Handle restored purchases in iOS example app (flutter#4392) [file_selector] Remove custom analysis options (flutter#4382) [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373) Fixed _CastError when running example App (flutter#4390) [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370) ...# Conflicts:#packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
Uh oh!
There was an error while loading.Please reload this page.
This PR helps avoid unnecessary loss of longitude precision in the
LatLngconstructor.See issue for more details.
Issues:
Fixesflutter/flutter#90574
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.