This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add false secret lists, and enforce ordering#4372
Merged
fluttergithubbot merged 2 commits intoflutter:masterfromSep 22, 2021
Merged
Add false secret lists, and enforce ordering#4372fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
ditman approved these changesSep 22, 2021
Member
ditman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ship it!
fluttergithubbot commentedSep 22, 2021
This pull request is not suitable for automatic merging in its current state.
|
Member
ditman commentedSep 22, 2021
(Restarted broken task, it was a timeout) |
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 22, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 22, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 22, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull requestSep 27, 2021
* master: (51 commits) [webview_flutter] Update version number app_facing package (flutter#4375) [webview_flutter] Adjust integration test domains (flutter#4383) Remove some trivial custom analysis options files (flutter#4379) [google_maps_flutter_platfomr_interface] Add Marker drag events (flutter#2653) [flutter_plugin_tools] Improve version check error handling (flutter#4376) [flutter_plugin_tools] Allow overriding breaking change check (flutter#4369) [url_launcher] Error handling when URL cannot be parsed with Uri.parse (flutter#4365) [webview_flutter] Migrate main package to fully federated architecture. (flutter#4366) [google_sign_in] Bump minimum Flutter version and iOS deployment target (flutter#4334) Add false secret lists, and enforce ordering (flutter#4372) [camera_web] Update usage documentation (flutter#4371) [video_player] VTT Support (flutter#2878) Require authors file (flutter#4367) [flutter_plugin_tools] Fix federated safety check (flutter#4368) [webview_flutter] Extract WKWebView implementation into a separate package (flutter#4345) [webview_flutter] Extract Android implementation into a separate package (flutter#4343) [in_app_purchase] Ensure the `introductoryPriceMicros` field is populated correctly. (flutter#4364) [flutter_plugin_tools] Add a federated PR safety check (flutter#4329) [camera] Add web support (flutter#4240) [webview_flutter] Bump minimum Flutter version and iOS deployment target (flutter#4361) ...# Conflicts:#packages/webview_flutter/webview_flutter/lib/platform_interface.dart#packages/webview_flutter/webview_flutter/lib/src/webview_method_channel.dart#packages/webview_flutter/webview_flutter/lib/webview_flutter.dart
KyleFin pushed a commit to KyleFin/plugins that referenced this pull requestDec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
cla: yesp: google_maps_flutterp: google_sign_inplatform-webwaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates plugins to pass the new publish check against leaking secrets, and adds the new
false_secretssection to the enforced section ordering in the tool. This prevents future unrelated failures when trying to publish these plugins.Fixesflutter/flutter#90477
Pre-launch Checklist
dart format.)[shared_preferences]///).