This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[flutter_plugin_tools] Allow overriding breaking change check#4369
Merged
fluttergithubbot merged 6 commits intoflutter:masterfromSep 23, 2021
Merged
Conversation
a222ec9 to082ed06Compare082ed06 to39d13f1CompareThis reverts commit39d13f1.
ditman approved these changesSep 22, 2021
Member
ditman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
I would have loved to be able to override even more the version number (to jump from 0.2.0 to 0.6.0 :P) but this is more to the point, and keeps the processes saner. 🚀
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
stuartmorgan-g commentedSep 23, 2021
I was keeping that use case in mind while writing this; it would be relatively straightforward to extend this to cover that if we find another time where we feel that we need it. |
| final File file = packagesDir.fileSystem.file(path); | ||
| if (!file.existsSync()) { | ||
| printError('${indentation}No such file: $path'); | ||
| throw ToolExit(_exitMissingChangeDescriptionFile); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, since this file (and its path) are managed by the cirrus.yaml, it makes more sense that this is a tool exit error, good call! 🚀
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 23, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull requestSep 27, 2021
* master: (51 commits) [webview_flutter] Update version number app_facing package (flutter#4375) [webview_flutter] Adjust integration test domains (flutter#4383) Remove some trivial custom analysis options files (flutter#4379) [google_maps_flutter_platfomr_interface] Add Marker drag events (flutter#2653) [flutter_plugin_tools] Improve version check error handling (flutter#4376) [flutter_plugin_tools] Allow overriding breaking change check (flutter#4369) [url_launcher] Error handling when URL cannot be parsed with Uri.parse (flutter#4365) [webview_flutter] Migrate main package to fully federated architecture. (flutter#4366) [google_sign_in] Bump minimum Flutter version and iOS deployment target (flutter#4334) Add false secret lists, and enforce ordering (flutter#4372) [camera_web] Update usage documentation (flutter#4371) [video_player] VTT Support (flutter#2878) Require authors file (flutter#4367) [flutter_plugin_tools] Fix federated safety check (flutter#4368) [webview_flutter] Extract WKWebView implementation into a separate package (flutter#4345) [webview_flutter] Extract Android implementation into a separate package (flutter#4343) [in_app_purchase] Ensure the `introductoryPriceMicros` field is populated correctly. (flutter#4364) [flutter_plugin_tools] Add a federated PR safety check (flutter#4329) [camera] Add web support (flutter#4240) [webview_flutter] Bump minimum Flutter version and iOS deployment target (flutter#4361) ...# Conflicts:#packages/webview_flutter/webview_flutter/lib/platform_interface.dart#packages/webview_flutter/webview_flutter/lib/src/webview_method_channel.dart#packages/webview_flutter/webview_flutter/lib/webview_flutter.dart
KyleFin pushed a commit to KyleFin/plugins that referenced this pull requestDec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
cla: yeswaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adds the ability to override the current prohibition against breaking changes to platform interfaces with a justification (following a set pattern, which will be documented in the wiki) in the PR description. This fixes the incorrect hard limit that's currently in place, but ensures that there is enough extra process that:
Fixesflutter/flutter#85391
Pre-launch Checklist
dart format.)[shared_preferences]///).