Sep 21, 2021 · Sep 21, 2021
diff --git a/script/tool/lib/src/federation_safety_check_command.dart b/script/tool/lib/src/federation_safety_check_command.dart
      return PackageResult.success();
    }

    final List<String> changedPackageFiles =
        _changedDartFiles[package.directory.basename] ?? <String>[];
    if (changedPackageFiles.isEmpty) {
      print('No Dart changes.');
      return PackageResult.success();
    }

    // If the change would be flagged, but it appears to be a mass change
    // rather than a plugin-specific change, allow it with a warning.
    //
diff --git a/script/tool/test/federation_safety_check_command_test.dart b/script/tool/test/federation_safety_check_command_test.dart
    );
  });

  test('allows changes to just an interface package', () async {
    final Directory pluginGroupDir = packagesDir.childDirectory('foo');
    final Directory platformInterface =
        createFakePlugin('foo_platform_interface', pluginGroupDir);
    createFakePlugin('foo', pluginGroupDir);
    createFakePlugin('foo_ios', pluginGroupDir);
    createFakePlugin('foo_android', pluginGroupDir);

    final String changedFileOutput = <File>[
      platformInterface.childDirectory('lib').childFile('foo.dart'),
      platformInterface.childFile('pubspec.yaml'),
    ].map((File file) => file.path).join('\n');
    processRunner.mockProcessesForExecutable['git-diff'] = <io.Process>[
      MockProcess(stdout: changedFileOutput),
    ];

    final List<String> output =
        await runCapturingPrint(runner, <String>['federation-safety-check']);

    expect(
      output,
      containsAllInOrder(<Matcher>[
        contains('Running for foo/foo...'),
        contains('No Dart changes.'),
        contains('Running for foo_android...'),
        contains('No Dart changes.'),
        contains('Running for foo_ios...'),
        contains('No Dart changes.'),
        contains('Running for foo_platform_interface...'),
        contains('Ran for 3 package(s)'),
        contains('Skipped 1 package(s)'),
      ]),
    );
    expect(
      output,
      isNot(contains(<Matcher>[
        contains('No published changes for foo_platform_interface'),
      ])),
    );
  });

  test('allows changes to multiple non-interface packages', () async {
    final Directory pluginGroupDir = packagesDir.childDirectory('foo');
    final Directory appFacing = createFakePlugin('foo', pluginGroupDir);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -135,6 +135,13 @@ class FederationSafetyCheckCommand extends PackageLoopingCommand {
		return PackageResult.success();
		}

		final List<String> changedPackageFiles =
		_changedDartFiles[package.directory.basename] ?? <String>[];
		if (changedPackageFiles.isEmpty) {
		print('No Dart changes.');
		return PackageResult.success();
		}

		// If the change would be flagged, but it appears to be a mass change
		// rather than a plugin-specific change, allow it with a warning.
		//
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -125,6 +125,47 @@ void main() {
		);
		});

		test('allows changes to just an interface package', () async {
		final Directory pluginGroupDir = packagesDir.childDirectory('foo');
		final Directory platformInterface =
		createFakePlugin('foo_platform_interface', pluginGroupDir);
		createFakePlugin('foo', pluginGroupDir);
		createFakePlugin('foo_ios', pluginGroupDir);
		createFakePlugin('foo_android', pluginGroupDir);

		final String changedFileOutput = <File>[
		platformInterface.childDirectory('lib').childFile('foo.dart'),
		platformInterface.childFile('pubspec.yaml'),
		].map((File file) => file.path).join('\n');
		processRunner.mockProcessesForExecutable['git-diff'] = <io.Process>[
		MockProcess(stdout: changedFileOutput),
		];

		final List<String> output =
		await runCapturingPrint(runner, <String>['federation-safety-check']);

		expect(
		output,
		containsAllInOrder(<Matcher>[
		contains('Running for foo/foo...'),
		contains('No Dart changes.'),
		contains('Running for foo_android...'),
		contains('No Dart changes.'),
		contains('Running for foo_ios...'),
		contains('No Dart changes.'),
		contains('Running for foo_platform_interface...'),
		contains('Ran for 3 package(s)'),
		contains('Skipped 1 package(s)'),
		]),
		);
		expect(
		output,
		isNot(contains(<Matcher>[
		contains('No published changes for foo_platform_interface'),
		])),
		);
		});

		test('allows changes to multiple non-interface packages', () async {
		final Directory pluginGroupDir = packagesDir.childDirectory('foo');
		final Directory appFacing = createFakePlugin('foo', pluginGroupDir);
Expand Down