- Notifications
You must be signed in to change notification settings - Fork9.7k
[image_picker] Bump minimum Flutter version and iOS deployment target#4335
[image_picker] Bump minimum Flutter version and iOS deployment target#4335fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
| GCC_WARN_UNUSED_FUNCTION = YES; | ||
| GCC_WARN_UNUSED_VARIABLE = YES; | ||
| IPHONEOS_DEPLOYMENT_TARGET =8.0; | ||
| IPHONEOS_DEPLOYMENT_TARGET =9.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same, done automatically viaflutter/flutter#85174.
| </array> | ||
| <key>MinimumOSVersion</key> | ||
| <string>8.0</string> | ||
| <string>9.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was done automatically viaflutter/flutter#85174 by justflutter building the example project.
| repository: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22 | ||
| version: 0.8.4 | ||
| version: 0.8.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
similar to the google map PR, 0.8.4+1 is probably enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
stuartmorgan-g left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
nguyenlamzx commentedSep 22, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@jmagman can we keep the previous sdk constrains? because there're many packages didn't update to sdk and I using this package along with other packages. For now, I use old version |
jmagman commentedSep 22, 2021
Or you can comment onflutter/flutter#84198 |
Flutter apps run on 2.4.0-0.0.pre and laterwill be upgraded to a minimum of iOS 9.0. Now that Flutter 2.5 has hit stable andiOS 8 support has been dropped, change the plugin minimum iOS version to
9.0.Bump the Flutter and dart version constraints to 2.5 and 2.14 respectively to enforce that the iOS 9.0 migration has happened on the app side, because an older 8.0 app won't build with a 9.0 plugin. I believe the last time this was done was a few months ago for null safety adoption#3324 (there's recent precedent).
Users on Flutter versions lower than the current stable 2.5 will not be able to upgrade this plugin past this version.
image_picker part offlutter/flutter#84198
Pre-launch Checklist
dart format.)[shared_preferences]///).