Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[image_picker] Bump minimum Flutter version and iOS deployment target#4335

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jmagman:ip-9
Sep 17, 2021
Merged

[image_picker] Bump minimum Flutter version and iOS deployment target#4335
fluttergithubbot merged 1 commit intoflutter:masterfrom
jmagman:ip-9

Conversation

@jmagman
Copy link
Member

Flutter apps run on 2.4.0-0.0.pre and laterwill be upgraded to a minimum of iOS 9.0. Now that Flutter 2.5 has hit stable andiOS 8 support has been dropped, change the plugin minimum iOS version to9.0.

Bump the Flutter and dart version constraints to 2.5 and 2.14 respectively to enforce that the iOS 9.0 migration has happened on the app side, because an older 8.0 app won't build with a 9.0 plugin. I believe the last time this was done was a few months ago for null safety adoption#3324 (there's recent precedent).

Users on Flutter versions lower than the current stable 2.5 will not be able to upgrade this plugin past this version.

image_picker part offlutter/flutter#84198

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does usedart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.[shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • Iupdated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET =8.0;
IPHONEOS_DEPLOYMENT_TARGET =9.0;
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same, done automatically viaflutter/flutter#85174.

</array>
<key>MinimumOSVersion</key>
<string>8.0</string>
<string>9.0</string>
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was done automatically viaflutter/flutter#85174 by justflutter building the example project.

repository: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
version: 0.8.4
version: 0.8.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

similar to the google map PR, 0.8.4+1 is probably enough.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done.

Copy link
Contributor

@stuartmorgan-gstuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@jmagmanjmagman added the waiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labelSep 17, 2021
@fluttergithubbotfluttergithubbot merged commit701fdb6 intoflutter:masterSep 17, 2021
@jmagmanjmagman deleted the ip-9 branchSeptember 17, 2021 02:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestSep 18, 2021
@nguyenlamzx
Copy link

nguyenlamzx commentedSep 22, 2021
edited
Loading

@jmagman can we keep the previous sdk constrains? because there're many packages didn't update to sdk and I using this package along with other packages.

For now, I use old versionimage_picker: 0.8.4+1 to be able to install successfully

@jmagman
Copy link
MemberAuthor

@jmagman can we keep the previous sdk constrains? because there're many packages didn't update to sdk and I using this package along with other packages.

For now, I use old versionimage_picker: 0.8.4+1 to be able to install successfully

From701fdb6#r56918265

Flutter 2.5 shipped with Dart 2.14, so that's the minimum of the range. You can see influtter/flutter#84198 why we wanted to target 2.5, namely we need to make sure all consumers of the plugin have upgraded their apps to iOS 9 or later before this plugin could drop support for iOS 8.
If you're seeing an issue related to this bump, please file a new issue so the ecosystem team can evaluate this strategy.

Or you can comment onflutter/flutter#84198

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@cyanglazcyanglazcyanglaz left review comments

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagmanjmagman

Labels

cla: yesp: image_pickerplatform-ioswaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmagman@nguyenlamzx@stuartmorgan-g@cyanglaz@fluttergithubbot

Comments


[8]ページ先頭

©2009-2026 Movatter.jp