- Notifications
You must be signed in to change notification settings - Fork9.7k
Revert "[image_picker] add forceFullMetadata to interface"#4314
Revert "[image_picker] add forceFullMetadata to interface"#4314stuartmorgan-g merged 3 commits intomasterfrom
Conversation
This reverts commit998f51f.
| # NOTE: We strongly prefer non-breaking changes, even at the expense of a | ||
| # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes | ||
| version: 2.4.0 | ||
| version: 2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can't revert the version, because 2.3.0 and 2.4.0 are already published. This should be 2.4.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
stuartmorgan-g commentedSep 5, 2021
It published a breaking change as if it weren't breaking. |
stuartmorgan-g commentedSep 5, 2021
The reasons things are red is because it's using the published, broken version of the interface package to analyze web. I think we'll need to force-land this and break the tree temporarily, then publish on red, to fix it. This is quite a mess. I will take a look later. |
stuartmorgan-g commentedSep 5, 2021
I think I may be able to fix this forward in a way that won't require bypassing all of our testing safeties; let me see if that will work. |
stuartmorgan-g commentedSep 6, 2021
No, I forgot that Dart doesn't allow C-style function overloading. That makes what I had in mind impossible. I think I just have to push this through a bunch of red. I'll manually check all the failures here and make sure they are exactly what I expect from this situation. |
stuartmorgan-g commentedSep 6, 2021
|
stuartmorgan-g left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I will force land this, which will in turn turn the tree red. I'll then manually publishimage_picker_platform_interface, which should fix everything (including flutter/flutter) and then re-run the post-submit tests to green the tree.
(Actually, if I publish fast enough I might be able to beat at least some of the post-submit tests...)
* master: (490 commits) Allow neutral conclusion in publishing check (flutter#4321) Revert "[image_picker] add forceFullMetadata to interface" (flutter#4314) [image_picker] add forceFullMetadata to interface (flutter#4288) [flutter_plugin_tools] Adjust diff logging (flutter#4312) Remove gradle.properties from plugins (flutter#4309) build-examples .pluginToolsConfig.yaml support (flutter#4305) [camera_web] Make plugin publishable for the first time. (flutter#4304) adds option to re-authenticate on google silent sign in (flutter#4251) [ci.yaml] Add builders to recipes cq (flutter#4306) Add scripts for Windows LUCI recipe (flutter#4303) [video_player] Ensure seekTo is not called before video player is initialized. (flutter#4300) Ensure setExposureOffset returns new value on Android (flutter#4301) Add a way to opt a file out of Dart formatting (flutter#4292) [flutter_plugin_tools] Add Linux support to native-test (flutter#4294) [image_picker]Android update cache (flutter#4124) [flutter_plugin_tools] Fix build-examples for packages (flutter#4248) [flutter_plugin_tool] Migrate 'publish' to new base command (flutter#4290) [flutter_plugin_tool] Move branch-switching logic from tool_runner.sh to tool (flutter#4268) [flutter_plugin_tool] Add support for running Windows unit tests (flutter#4276) [camera_web] Do not flip the video on the back camera (flutter#4281) ...# Conflicts:#packages/webview_flutter/webview_flutter/CHANGELOG.md#packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java#packages/webview_flutter/webview_flutter/pubspec.yaml
)Revertsflutter#4288 which published a breaking change as if it were a non-breaking change.The discussion in that PR prior to it landing was incorrect, because adding a new parameterwith a default value is non-breaking *only for clients*. It is breaking for subclasses thatoverride it, and the purpose of the platform interface is for implementations to subclass itand override everything.
)Revertsflutter#4288 which published a breaking change as if it were a non-breaking change.The discussion in that PR prior to it landing was incorrect, because adding a new parameterwith a default value is non-breaking *only for clients*. It is breaking for subclasses thatoverride it, and the purpose of the platform interface is for implementations to subclass itand override everything.
)Revertsflutter#4288 which published a breaking change as if it were a non-breaking change.The discussion in that PR prior to it landing was incorrect, because adding a new parameterwith a default value is non-breaking *only for clients*. It is breaking for subclasses thatoverride it, and the purpose of the platform interface is for implementations to subclass itand override everything.
Uh oh!
There was an error while loading.Please reload this page.
Reverts#4288
FYI@cpboyd
This commit appears to be breaking the framework tree somehow:https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20flutter_plugins/3301/overview
Fixesflutter/flutter#89517