Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[camera] Replace device info with new device_info_plus#4265

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
mhadaily:patch-1
Aug 26, 2021
Merged

[camera] Replace device info with new device_info_plus#4265
fluttergithubbot merged 4 commits intoflutter:masterfrom
mhadaily:patch-1

Conversation

@mhadaily
Copy link
Member

@mhadailymhadaily commentedAug 25, 2021
edited
Loading

this plugin has been replaced by the Flutter Community Plus Plugins version, device_info_plus. No further updates are planned to this plugin, and we encourage all users to migrate to the Plus version.

Pre-launch Checklist

  • I read theContributor Guide and followed the process outlined there for submitting PRs.
  • I read theTree Hygiene wiki page, which explains my responsibilities.
  • I read and followed therelevant style guides and ranthe auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does usedart format.)
  • I signed theCLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.[shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • Iupdated pubspec.yaml with an appropriate new version according to thepub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

this plugin has been replaced by the Flutter Community Plus Plugins version, device_info_plus. No further updates are planned to this plugin, and we encourage all users to migrate to the Plus version.
@stuartmorgan-g
Copy link
Contributor

Please don't just check checkboxes indiscriminately; this PR doesn't currently do either of this things, and needs to.

@mhadaily
Copy link
MemberAuthor

I'm sorry@stuartmorgan I just didn't know whether I should really add anything to pubspec or changelog as this PR is only changing the README file.

Do you think I should pump the version and add a changelog because of this change? if so, I'll do it right away.

@stuartmorgan-g
Copy link
Contributor

This is discussed in the first link on that line.

Is the issue that the discussion it links to isn't clear about this case, or that you didn't realize that link would answer this question? I'd like to fix the template and/or wiki to avoid this in the future.

@mhadaily
Copy link
MemberAuthor

mhadaily commentedAug 25, 2021
edited
Loading

I trusted myself more than I must due to my previous contribution.@stuartmorgan that is obviously my fault where I didn't read carefully.

here is the text if someone sees this PR later, just in case.

Do I need to update the version if I'm just changing the README? Yes. Most people read the README on pub.dev, not GitHub, so a README change is not very useful until it's published.

Fixed now.

@mhadailymhadaily changed the titleReplace device info with new device_info_plus[camera] Replace device info with new device_info_plusAug 25, 2021
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commentedAug 25, 2021
edited
Loading

@stuartmorgan that is obviously my fault where I didn't read carefully.

You're not the first person to have missed it, which suggests that the documentation is at fault. I'd like to figure out whether people are following the link but missing the FAQ, or if they aren't following the link at all, so that I can figure out where to make adjustments.

@@ -1,3 +1,7 @@
## 0.9.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: 0.9.1+1 per the discussion of pre-1.0 versionshere.

@mhadaily
Copy link
MemberAuthor

Well,
I actually opened that link and just read the first paragraph. As soon as I saw the FAQ, I ignored the questions and skipped it until the next section. Since I contributed before, I didn't think even for a second that might help, that's probably my fault.

I am not sure if this is a fault in the documentation. It's probably me that I should have paid attention to the whole text.

Copy link
Contributor

@stuartmorgan-gstuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@stuartmorgan-gstuartmorgan-g added waiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. last mile labelsAug 26, 2021
@fluttergithubbotfluttergithubbot merged commit46dd609 intoflutter:masterAug 26, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestAug 26, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull requestSep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines

1 more reviewer

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesp: camerawaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhadaily@stuartmorgan-g@fluttergithubbot@stuartmorgan

Comments


[8]ページ先頭

©2009-2026 Movatter.jp