This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ci] update wait-on-check version and set verbose to false#4262
Merged
cyanglaz merged 3 commits intoflutter:masterfromAug 27, 2021
Merged
[ci] update wait-on-check version and set verbose to false#4262cyanglaz merged 3 commits intoflutter:masterfrom
cyanglaz merged 3 commits intoflutter:masterfrom
Conversation
stuartmorgan-g approved these changesAug 25, 2021
Contributor
stuartmorgan-g left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for following up on it!
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestAug 27, 2021
Member
ditman commentedAug 27, 2021
Yeeessss, amazing! |
This was referencedAug 27, 2021
stuartmorgan-g pushed a commit that referenced this pull requestAug 28, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull requestSep 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull requestSep 13, 2021
…utter#4289)Relandsflutter#4262 as the white list has been updated to allow the newer wait-on-check version.
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
…utter#4289)Relandsflutter#4262 as the white list has been updated to allow the newer wait-on-check version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Thiscommit has added a
verboseproperty for wait-on-check which greatly reduce the output.Each wait interval still produces an output so we still keep the 3 min interval for now so the output won't be too overwhelming.
This is tested in my personal repo here:https://github.com/cyanglaz/melos_test/runs/3414623441?check_suite_focus=true
Fixesflutter/flutter#85127
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.