This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[camera_web] Add missingsetFlashMode test#4235
Merged
ditman merged 1 commit intoflutter:masterfromAug 12, 2021
VeryGoodOpenSource:test/camera-web-add-missing-set-flash-mode-test
Merged
[camera_web] Add missingsetFlashMode test#4235ditman merged 1 commit intoflutter:masterfromVeryGoodOpenSource:test/camera-web-add-missing-set-flash-mode-test
setFlashMode test#4235ditman merged 1 commit intoflutter:masterfrom
VeryGoodOpenSource:test/camera-web-add-missing-set-flash-mode-test
Conversation
ContributorAuthor
bselwe commentedAug 12, 2021
ditman approved these changesAug 12, 2021
Member
ditman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Thanks for the test! (Did I mess this one up in my merges?)
ContributorAuthor
bselwe commentedAug 13, 2021
@ditman I think I just forgot about this one. 😄 |
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestAug 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull requestSep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing
CameraPlugin.setFlashModetest to verify if the method is called on theCamerawith the given id.Part offlutter/flutter#45297.
Pre-launch Checklist
dart format.)[shared_preferences]///).