Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[camera_web] Handle camera errors intakePicture#4230

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
VeryGoodOpenSource:feat/camera-web-handle-camera-errors-in-take-picture
Aug 12, 2021
Merged

[camera_web] Handle camera errors intakePicture#4230
fluttergithubbot merged 2 commits intoflutter:masterfrom
VeryGoodOpenSource:feat/camera-web-handle-camera-errors-in-take-picture

Conversation

@bselwe
Copy link
Contributor

Added handling of camera errors intakePicture. The method may throw aCameraWebException after changes introduced in#4222. The exception is handled by throwing aPlatformException and emitting a camera error event on theonCameraError stream.

Part offlutter/flutter#45297.

Pre-launch Checklist

  • I read theContributor Guide and followed the process outlined there for submitting PRs.
  • I read theTree Hygiene wiki page, which explains my responsibilities.
  • I read and followed therelevant style guides and ranthe auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does usedart format.)
  • I signed theCLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.[shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • Iupdated pubspec.yaml with an appropriate new version according to thepub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe
Copy link
ContributorAuthor

@ditman@felangel

Copy link
Member

@ditmanditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's go!

@ditmanditman added the waiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labelAug 12, 2021
@fluttergithubbotfluttergithubbot merged commit4383bb1 intoflutter:masterAug 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestAug 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull requestSep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull requestSep 27, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines

1 more reviewer

@ditmanditmanditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesp: cameraplatform-webwaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bselwe@ditman@fluttergithubbot

Comments


[8]ページ先頭

©2009-2026 Movatter.jp