Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[camera_web] Recording Video#4210

Merged
ditman merged 32 commits intoflutter:masterfromABausG:camera_web_recording
Sep 16, 2021
Merged
Changes from1 commit
Commits
Show all changes
32 commits
Select commitHold shift + click to select a range
0c6fac4
Add Support for Video Recording in Camera Web
ABausGJul 31, 2021
65b2718
Add Documentation
ABausGJul 31, 2021
4bd1173
Adding Tests
ABausGJul 31, 2021
ce42759
Adding Error Handling
ABausGJul 31, 2021
fdbe131
Formatting
ABausGJul 31, 2021
4b1ae4c
Add missing call to get RecordedEvent Stream
ABausGJul 31, 2021
2e6dfec
Rename onVideoRecordedEventStream
ABausGAug 5, 2021
f252ffc
Unify logic from startVideoRecording and stopVideoRecording
ABausGAug 5, 2021
d8114ab
throw PlatformExceptions
ABausGAug 5, 2021
39adc96
Use srcObject
ABausGAug 5, 2021
4db7748
Add Camera Tests
ABausGAug 5, 2021
287bd4a
Fix Test and Stopping Video Recording
ABausGAug 7, 2021
8f0f2fd
Clarify maxVideoDuration Test Issue
ABausGAug 7, 2021
0e1d690
Merge branch 'upstream/master' into camera_web_recording
bselweAug 30, 2021
d38978f
feat: await closing videoRecorderController in Camera
bselweAug 30, 2021
ce5c1ca
docs: update video recording comments
bselweAug 30, 2021
a517757
feat: throw a CameraWebException if the video recording fails
bselweAug 30, 2021
2d1022f
test: add onEnded and onVideoRecordedEvent dispose tests
bselweAug 31, 2021
01a6999
test: update Camera video recording tests
bselweAug 31, 2021
4df6796
test: add missing CameraPlatform video recording tests
bselweAug 31, 2021
1d3906d
Merge branch 'upstream/master' into camera_web_recording
bselweAug 31, 2021
3c74e9e
feat: combine ondataavailable video blobs into a single video blob
bselweSep 3, 2021
f5863e9
test: update video recording tests for multiple video blobs
bselweSep 3, 2021
4552b01
docs: add video recording documentation
bselweSep 13, 2021
cd7f80d
feat: add Camera onVideoRecordingError stream
bselweSep 13, 2021
01b3210
test: add Camera onVideoRecordingError stream tests
bselweSep 13, 2021
c03fea6
feat: emit a CameraErrorEvent on video recording error
bselweSep 13, 2021
194db74
test: emit a CameraErrorEvent on video recording error tests
bselweSep 13, 2021
24ab126
Merge branch 'upstream/master' into camera_web_recording
bselweSep 14, 2021
787ee6b
feat: make prepareForVideoRecording a no-op
bselweSep 14, 2021
bc9c72a
Merge branch 'master' into camera_web_recording
ditmanSep 16, 2021
114cc46
Update CHANGELOG and pubspec
ditmanSep 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Clarify maxVideoDuration Test Issue
MediaRecorder.start with a Timeslice does not seem to fire in the test case
  • Loading branch information
@ABausG
ABausG committedAug 7, 2021
commit8f0f2fdc2992dce173557f7c05fc546e7ea85b0d
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -317,8 +317,9 @@ void main() {
testWidgets(
'starts a video recording with a given maxDuration '
'emits a VideoRecordedEvent', (tester) async {
// TODO(abausg) There seems to be an issue with removing the listener and stopping the recorder
/*final maxDuration = Duration(milliseconds: 30);
// TODO: MediaRecorder with a Timeslice does not seem to call the dataavailable Listener in a Test
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I could not get this test to work. As it does not seem to trigger the datavailable event of the media recorder.
I was able to manually test the behaviour with setting a max duration (I tested with 4 seconds) however this test seems to timeout waiting for the first element of the event stream.
Could you take a look at what's might be going on?
Also is there a (nice) way to debug the integration tests?

Copy link
Contributor

@bselwebselweAug 9, 2021
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I will have a look at this test.

There is a way to debug integration tests in the browser. You'll need to execute this incamera_web/example:

flutter run -d web-server --target integration_test/camera_test.dart --debug

It will produce a link that you should open in the browser, open inspection tools (CMD+Option+J in Chrome), find a dart file you want to debug in the "Source" tab and mark a breakpoint. Refresh the web page and it should stop at the breakpoint.

ditman reacted with thumbs up emoji
/*
final maxDuration = Duration(milliseconds: 3000);

final camera = Camera(
textureId: 1,
Expand All@@ -328,11 +329,13 @@ void main() {
await camera.initialize();
await camera.play();

finaleventExpectation =expectLater(camera.onVideoRecordedEvent.map((event) => event.maxVideoDuration), emits(maxDuration));
finalrecordedEvent = camera.onVideoRecordedEvent.first;
await camera.startVideoRecording(maxVideoDuration: maxDuration);

await eventExpectation;
expect('inactive', camera.mediaRecorder!.state);*/
final event = await recordedEvent;
expect(event, isNotNull);
expect(event.maxVideoDuration, maxDuration);
*/
});

testWidgets(
Expand Down

[8]ページ先頭

©2009-2026 Movatter.jp