Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
/pluginsPublic archive

[image_picker]Android update cache#4124

Merged
fluttergithubbot merged 35 commits intoflutter:masterfrom
Baseflow:image_picker/android_update_cache
Sep 1, 2021
Merged

[image_picker]Android update cache#4124
fluttergithubbot merged 35 commits intoflutter:masterfrom
Baseflow:image_picker/android_update_cache

Conversation

@ydag
Copy link
Contributor

@ydagydag commentedJul 1, 2021
edited
Loading

This PR updates theImagePickerCache to cache multiple files.

Related issues :

If you had to change anything in theflutter/tests repo, include a link to the migration guide as per thebreaking change policy.

Pre-launch Checklist

  • I read theContributor Guide and followed the process outlined there for submitting PRs.
  • I read theTree Hygiene wiki page, which explains my responsibilities.
  • I read and followed therelevant style guides and ranthe auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does usedart format.)
  • I signed theCLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.[shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • Iupdated pubspec.yaml with an appropriate new version according to thepub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

PascalOtto reacted with thumbs up emoji
ydag added10 commitsJune 30, 2021 15:34
I removed the finishWithListSuccess method since it was a temporary solution to save only the last image when multiple images are picked. With the new implementation of caching, finishWithSuccess method save always a list of images to the cache.
Since we are saving always a list of images getCacheMap will return pathList by using the new MAP_KEY_PATH_LIST key. But to avoid breaking change, we are also returning MAP_KEY_PATH with the first element of the list.
I updated saveResult method to use putStringSet method for saving list of images to the cache.
ydag added3 commitsJuly 1, 2021 12:57
This reverts commit2d1a871.# Conflicts:#packages/image_picker/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
@ydagydag requested a review fromrenefloorJuly 1, 2021 12:59
# Conflicts:#packages/image_picker/image_picker/CHANGELOG.md#packages/image_picker/image_picker/pubspec.yaml
@ydagydag marked this pull request as draftJuly 16, 2021 14:12
Copy link
Contributor

@BeMacizedBeMacized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll take a look at this one again once the platform interface changes are merged, but already two nits below as they were also in the other PR.

This test is removed because `multiRetrieved` method call was removed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@cyanglazcyanglazAwaiting requested review from cyanglaz

@renefloorrenefloorAwaiting requested review from renefloor

2 more reviewers

@BeMacizedBeMacizedBeMacized approved these changes

@mvanbeusekommvanbeusekommvanbeusekom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesp: image_pickerplatform-androidwaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[image_picker] Update the cache on Android

5 participants

@ydag@BeMacized@mvanbeusekom@renefloor@fluttergithubbot

Comments


[8]ページ先頭

©2009-2026 Movatter.jp