This repository was archived by the owner on Feb 22, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[image_picker]Android update cache#4124
Merged
fluttergithubbot merged 35 commits intoflutter:masterfromSep 1, 2021
Merged
Conversation
I removed the finishWithListSuccess method since it was a temporary solution to save only the last image when multiple images are picked. With the new implementation of caching, finishWithSuccess method save always a list of images to the cache.
Since we are saving always a list of images getCacheMap will return pathList by using the new MAP_KEY_PATH_LIST key. But to avoid breaking change, we are also returning MAP_KEY_PATH with the first element of the list.
I updated saveResult method to use putStringSet method for saving list of images to the cache.
Uh oh!
There was an error while loading.Please reload this page.
...r/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit2d1a871.# Conflicts:#packages/image_picker/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
# Conflicts:#packages/image_picker/image_picker/CHANGELOG.md#packages/image_picker/image_picker/pubspec.yaml
BeMacized suggested changesAug 19, 2021
Contributor
BeMacized left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll take a look at this one again once the platform interface changes are merged, but already two nits below as they were also in the other PR.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
BeMacized suggested changesAug 19, 2021
...r/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
This test is removed because `multiRetrieved` method call was removed.
This was referencedSep 8, 2021
This was referencedSep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
cla: yesp: image_pickerplatform-androidwaiting for tree to go green(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR updates the
ImagePickerCacheto cache multiple files.Related issues :
If you had to change anything in theflutter/tests repo, include a link to the migration guide as per thebreaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.