Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ci] Pins github action commit hash#10599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chunhtai wants to merge3 commits intoflutter:main
base:main
Choose a base branch
Loading
fromchunhtai:pins-hash

Conversation

@chunhtai
Copy link
Contributor

@chunhtaichunhtai commentedDec 10, 2025
edited
Loading

as title. This is required due to our policy

context:flutter/flutter#179033

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

Note: The Flutter team is currently trialing the use ofGemini Code Assist for GitHub. Comments from thegemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.23

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Collaborator

@stuartmorgan-gstuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but could you also add all the new workflow scriptshere? I forgot about it before, but was reminded by the flake in expensive tests on this PR; adding them to the ignore list will avoid that problem for future PRs (although not this one since tool changes trigger all tests too).

@chunhtai
Copy link
ContributorAuthor

Hi@stuartmorgan-g , do you think we should add the entire .github/workflows/* into the ignored this?

@stuartmorgan-g
Copy link
Collaborator

I was trying to be as conservative as possible (per the comment a few lines up from where I linked), but I think doing apath.startsWith('.github/workflows/') should be safe enough.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunhtai@stuartmorgan-g

[8]ページ先頭

©2009-2025 Movatter.jp