- Notifications
You must be signed in to change notification settings - Fork3.6k
[google_maps_flutter_ios] Add Advanced marker support#10508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jokerttu wants to merge1 commit intoflutter:mainChoose a base branch fromCodemateLtd:feature/advanced_markers_google_maps_flutter_ios
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
[google_maps_flutter_ios] Add Advanced marker support#10508
jokerttu wants to merge1 commit intoflutter:mainfromCodemateLtd:feature/advanced_markers_google_maps_flutter_ios
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8f811e9 to26fd75aCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Advanced markers support to the iOS implementation of
google_maps_flutter.Approved combined PR:#7882
Approved and merged platform interface PR:#9737
Issue:flutter/flutter#155526
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to thepub versioning philosophy, or I have commented below to indicate whichversion change exemption this PR falls under1.CHANGELOG.mdto add a description of the change,following repository CHANGELOG style, or I have commented below to indicate whichCHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.
Note: The Flutter team is currently trialing the use ofGemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.↩↩2↩3