Ignore analyzer implict dynamic checks for js_util generic return type#92271

Merged

fluttergithubbot merged 1 commit intoflutter:masterfrom

rileyporter:ignore_implicit_dynamic

Oct 21, 2021

Merged

Ignore analyzer implict dynamic checks for js_util generic return type#92271
fluttergithubbot merged 1 commit intoflutter:masterfrom
rileyporter:ignore_implicit_dynamic

Conversation

Copy link

Contributor

rileyporter commentedOct 21, 2021

Disables analyzer error for implicit dynamic functions when callingjs_util methods that have been changed to have a generic return type. My Dart change that caused the analyzer to have issueshere

Fixes:#92181

Pre-launch Checklist

I read theContributor Guide and followed the process outlined there for submitting PRs.
I read theTree Hygiene wiki page, which explains my responsibilities.
I read and followed theFlutter Style Guide, includingFeatures we expect every widget to implement.
I signed theCLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with///).
I added new tests to check the change I am making, or this PR istest-exempt.
no semantic changes, should be test-exempt?
All existing and new tests are passing.
I don't have flutter built locally, figured it was faster to get this out for review to fix the P0 break. In the meantime figuring out how to build locally to runflutter test

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

Ignore analyzer implict dynamic checks for js_util generic return type

47aab63

flutter-dashboardbot added a: text input

Entering text in a text field or keyboard related problems

f: integration_test

The flutter/packages/integration_test plugin

c: contributor-productivityTeam-specific productivity, code health, technical debt. labels

Oct 21, 2021

Copy link

flutter-dashboardbot commentedOct 21, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel inChat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

google-clabot added the cla: yes label

Oct 21, 2021

rileyporter mentioned this pull request

Oct 21, 2021

Engine -> Framework roll failing on new analyzer lints#92181

Closed

devoncarew approved these changes

Oct 21, 2021

View reviewed changes

Copy link

Contributor

devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

Copy link

ContributorAuthor

rileyporter commentedOct 21, 2021

@devoncarew I don't think I have access to add thewaiting-for-tree-to-go-green label, assuming that is also the process for submittingfluter/flutter pull requests. Feel free to do whatever you need to do to get the PR landed, thanks!