- Notifications
You must be signed in to change notification settings - Fork30k
Enableprefer_relative_imports and fix files.#91573
Enableprefer_relative_imports and fix files.#91573fluttergithubbot merged 1 commit intoflutter:masterfrom
prefer_relative_imports and fix files.#91573Conversation
I left it disabled in the flutter framework itself because it doesn't like our "subpackages" (e.g. `import 'package:flutter/framework.dart'`), but I think we have other bespoke tests that enforce it there anyway so it's not a big deal.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel inChat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hixie commentedOct 10, 2021
goderbauer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Hixie commentedOct 11, 2021
test-exempt: code refactor with no semantic change, enables lint |
I left it disabled in the flutter framework itself because it doesn't like our "subpackages" (e.g.
import 'package:flutter/framework.dart'), but I think we have other bespoke tests that enforce it there anyway so it's not a big deal.