- Notifications
You must be signed in to change notification settings - Fork30k
Migrate iOS project to Xcode 13 compatibility#90304
Merged
fluttergithubbot merged 2 commits intoflutter:masterfromSep 22, 2021
Merged
Migrate iOS project to Xcode 13 compatibility#90304fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
jmagman commentedSep 18, 2021
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion ="1020" | ||
| LastUpgradeVersion ="1300" |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The template was missed as part of#88074.
| testWithoutContext('skipped if nothing to upgrade', () { | ||
| const String xcodeProjectInfoFileContents = ''' | ||
| objectVersion = 50; | ||
| LastUpgradeCheck = 1300; |
Contributor
christopherfujinoSep 21, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ubernit: is this indentation right?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right, will fix. It doesn't matter for the test since whitespace is ignored.
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Edit: Actually it is "right" in that it looks like
classes = {};objectVersion = 50;objects = {attributes = {LastUpgradeCheck = 1300;And I just left off the extra lines. But I will include them since that's a better test (that no part of the file is edited)
christopherfujino approved these changesSep 21, 2021
Contributor
christopherfujino left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit about indentation but LGTM
cyanglaz approved these changesSep 21, 2021
Contributor
cyanglaz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
clocksmith pushed a commit to clocksmith/flutter that referenced this pull requestOct 29, 2021
8 tasks
This was referencedMay 1, 2023
auto-submitbot pushed a commit that referenced this pull requestMay 2, 2023
1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.2. Update iOS and macOS templates to same.3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.4. Run all example/integration test project to see migrator work.5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.Fixes#125817See#90304 for Xcode 13 example.
This was referencedDec 15, 2023
auto-submitbot pushed a commit that referenced this pull requestJan 3, 2024
Change the following in the `flutter create` templates. I didn't make any auto-migrations for existing apps because none seem that critical:1. Turn on `ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS` in iOS and macOS.1. Turn on `BuildIndependentTargetsInParallel` in macOS template.https://github.com/flutter/flutter/pull/125827/files#r1181817619 1. Turn on `DEAD_CODE_STRIPPING` in macOS template. 1. Set `ENABLE_USER_SCRIPT_SANDBOXING=NO` in iOS and macOS template. `flutter` scripts don't work with this on. This might require a migration in the future to explicitly turn this one off. However at least for now if the setting isn't present it defaults to `NO`.Add migration for `LastUpgradeVersion` so users won't see these validation issues in Xcode.Run migrator on all the example apps. A few aren't Flutter apps so I edited them in Xcode.Fixes#140253See also#125817 and#90304.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt. d: examplesSample code and demos platform-iosiOS applications specifically t: xcode"xcodebuild" on iOS and general Xcode project management toolAffects the "flutter" command-line tool. See also t: labels.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of the "Update to recommended settings" warning for existing iOS projects (shows up on all supported versions of Xcode) by migrating the project to change
LastUpgradeCheckandobjectVersionas already resolved by Xcode 13.Update the Swift Runner.xcscheme template missed in#88074.
Update the integration and other projects in the repo by running
flutter build ios.