- Notifications
You must be signed in to change notification settings - Fork30k
fix draggable_scrollable_sheet_test.dart#90204
Merged
yjbanov merged 1 commit intoflutter:masterfromSep 16, 2021
Merged
Conversation
zanderso approved these changesSep 16, 2021
Member
zanderso left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
rslgtm
jason-simmons approved these changesSep 16, 2021
ContributorAuthor
yjbanov commentedSep 16, 2021
I don't know why "Google testing" is stuck, but because this is a test-only change it should not affect anything in the "Google testing" category. I am therefore ignoring it and merging the PR to fix the P0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the loop over
TargetPlatform.values. It's redundant as each test already specifiesvariant: TargetPlatformVariant.all(). Having the loop simply causes the same tests to run over and over again, turning this 16-second test into a 1.5-min test on the VM, and a 1.5-min test into a 6.5-min test on the web, causing test timeouts.Thank you@jason-simmons for figuring out that this test was the culprit!
Fixes#90170