- Notifications
You must be signed in to change notification settings - Fork30k
Clean up dismissable_test to be less fragile#89870
Merged
gspencergoog merged 1 commit intoflutter:masterfromSep 20, 2021
Merged
Clean up dismissable_test to be less fragile#89870gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog merged 1 commit intoflutter:masterfrom
Conversation
Piinks approved these changesSep 13, 2021
Contributor
Piinks left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
clocksmith pushed a commit to clocksmith/flutter that referenced this pull requestOct 29, 2021
This cleans up the dismissable_test to be less fragile, and make it harder to forget to reset things between runs.I eliminated a bunch of globals that were susceptible to being missed and passed them in to buildTest instead, and removed some values that were always the same (itemExtent).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This cleans up the dismissable_test to be less fragile, and make it harder to forget to reset things between runs.
I eliminated a bunch of globals that were susceptible to being missed and passed them in to buildTest instead, and removed some values that were always the same (
itemExtent).